Attachment 340354 Details for Bug 185623 – Patch

[patch] Patch

bug-185623-20180514150125.patch (text/plain), 1.45 KB, created by Andy VanWagoner on 2018-05-14 14:01:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andy VanWagoner

Created: 2018-05-14 14:01:25 PDT

Size: 1.45 KB

patch

obsolete

>Subversion Revision: 231767
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 88c3ffa54359ef719556719852016ac420fe9d98..31bc121a8284044fb406f667b89302287b2bfa9a 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-14  Andy VanWagoner  <andy@vanwagoner.family>
>+
>+        [INTL] Handle error in defineProperty for supported locales length
>+        https://bugs.webkit.org/show_bug.cgi?id=185623
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Adds the missing RETURN_IF_EXCEPTION after defineOwnProperty for the
>+        length of the supported locales array.
>+
>+        * runtime/IntlObject.cpp:
>+        (JSC::supportedLocales):
>+
> 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [JSC] Tweak LiteralParser to improve lexing performance
>diff --git a/Source/JavaScriptCore/runtime/IntlObject.cpp b/Source/JavaScriptCore/runtime/IntlObject.cpp
>index ac74d7a561cad0b935e5b7d076ab9fa5b4dea120..68e0ca8ae1759e6c13024f70f872bbd8208b68ae 100644
>--- a/Source/JavaScriptCore/runtime/IntlObject.cpp
>+++ b/Source/JavaScriptCore/runtime/IntlObject.cpp
>@@ -856,6 +856,7 @@ JSValue supportedLocales(ExecState& state, const HashSet<String>& availableLocal
>         RETURN_IF_EXCEPTION(scope, JSValue());
>     }
>     supportedLocales->defineOwnProperty(supportedLocales, &state, vm.propertyNames->length, desc, true);
>+    RETURN_IF_EXCEPTION(scope, JSValue());
> 
>     return supportedLocales;
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 185623: 340354