Attachment 340352 Details for Bug 185571 – Patch

[patch] Patch

bug-185571-20180514134816.patch (text/plain), 2.01 KB, created by BJ Burg on 2018-05-14 13:48:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: BJ Burg

Created: 2018-05-14 13:48:17 PDT

Size: 2.01 KB

patch

obsolete

>Subversion Revision: 231759
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 6cd2a3e9b0dca0dd1640dcda71abf555aacb16d6..5c6c28b1db28d21ccd2f7f764b4a9a8de3c1368d 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-05-11  Brian Burg  <bburg@apple.com>
>+
>+        Web Automation: Automation.getBrowsingContext returns window origin that differs from window.screenX/Y
>+        https://bugs.webkit.org/show_bug.cgi?id=185571
>+        <rdar://problem/40180785>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This code path was refactored to use completion handlers. It seems that the window.screenX/Y
>+        code path converts back to user coordinates but the WebDriver code path does not. Make them
>+        consistent since that is how it is spec'd and tested.
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::getWindowFrameWithCallback):
>+        Convert the window frame to user coordinate space so it's the same as window.screenY.
>+
> 2018-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         -Wmemset-elt-size warning in LibWebRTCSocket constructor
>diff --git a/Source/WebKit/UIProcess/WebPageProxy.cpp b/Source/WebKit/UIProcess/WebPageProxy.cpp
>index a67ba08eebe49ef21a4a095781c94e84fb71cd2e..ee2595165eeb915fa6f5e5653b16992ad27d7d73 100644
>--- a/Source/WebKit/UIProcess/WebPageProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebPageProxy.cpp
>@@ -4437,7 +4437,9 @@ void WebPageProxy::getWindowFrame(Ref<Messages::WebPageProxy::GetWindowFrame::De
> 
> void WebPageProxy::getWindowFrameWithCallback(Function<void(FloatRect)>&& completionHandler)
> {
>-    m_uiClient->windowFrame(*this, WTFMove(completionHandler));
>+    m_uiClient->windowFrame(*this, [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)] (FloatRect frame) {
>+        completionHandler(m_pageClient.convertToUserSpace(frame));
>+    });
> }
> 
> void WebPageProxy::screenToRootView(const IntPoint& screenPoint, Ref<Messages::WebPageProxy::ScreenToRootView::DelayedReply>&& reply)

Flags:

timothy: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185571: 340235 | 340352