Attachment 340344 Details for Bug 185622 – Patch

[patch] Patch

bug-185622-20180514164620.patch (text/plain), 1.37 KB, created by Leo Balter on 2018-05-14 12:46:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Leo Balter

Created: 2018-05-14 12:46:22 PDT

Size: 1.37 KB

patch

obsolete

>Subversion Revision: 231767
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 2d5b861428cedc18f6a928735fc2e521cbedd545..de29ec0740583a84e0a6104fcc9add16e5e75085 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
>+
>+        Test262-Runner: Fix RegExp for capturing tests metadata"
>+        https://bugs.webkit.org/show_bug.cgi?id=185622
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
>+        both LF and CRLF forms.
>+        * Scripts/test262/Runner.pm:
>+        (parseData):
>+
> 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
> 
>         NSEvent event trackers don't work from WebKitTestRunner
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index 523e006883b4c3a5c2b14c859274936e17237bd5..71f12502d0e47b66ca9c3bd552d2b33a81b8b99e 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -707,7 +707,7 @@ sub parseData {
> 
>     my $parsed;
>     my $found = '';
>-    if ($contents =~ /\/\*(---\n[\S\s]*)\n---\*\//m) {
>+    if ($contents =~ /\/\*(---[\r\n]+[\S\s]*)[\r\n]+---\*\//m) {
>         $found = $1;
>     };
> 
>@@ -718,6 +718,7 @@ sub parseData {
>         print "\nError parsing YAML data on file $filename.\n";
>         print "$@\n";
>     };
>+
>     return $parsed;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185622: 340344 | 340350