Attachment 340330 Details for Bug 185617 – Patch

[patch] Patch

bug-185617-20180514105138.patch (text/plain), 1.48 KB, created by Jeremy Jones on 2018-05-14 10:51:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-05-14 10:51:38 PDT

Size: 1.48 KB

patch

obsolete

>Subversion Revision: 231175
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index f5230246676a60de86427223b4de85689e461c48..6260beff658b69f409daed2f383c7e7cae73603b 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-14  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Keyboard focus should exit fullscreen.
>+        https://bugs.webkit.org/show_bug.cgi?id=185617
>+        rdar://problem/34697938
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        While in element fullscreen, initiating keyboard focus should exit fullscreen.
>+
>+        * WebProcess/WebPage/WebPage.cpp:
>+        (WebKit::WebPage::elementDidFocus):
>+
> 2018-04-30  Alex Christensen  <achristensen@webkit.org>
> 
>         Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync
>diff --git a/Source/WebKit/WebProcess/WebPage/WebPage.cpp b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>index a82871d5691fba588ddb6655c435fbe71a1638b0..fc52621be1335978377ac4b5a86008c247c778ae 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>@@ -4909,6 +4909,10 @@ void WebPage::elementDidFocus(WebCore::Node* node)
>         m_assistedNode = node;
>         m_isAssistingNodeDueToUserInteraction |= m_userIsInteracting;
> 
>+#if ENABLE(FULLSCREEN_API)
>+        node->document().webkitCancelFullScreen();
>+#endif
>+
> #if PLATFORM(IOS)
>         ++m_currentAssistedNodeIdentifier;
>         AssistedNodeInformation information;

Actions: View | Formatted Diff | Diff

Attachments on bug 185617: 340330 | 341281 | 341295 | 341328 | 341332 | 341792