Attachment 340320 Details for Bug 185613 – Patch

[patch] Patch

bug-185613-20180515003606.patch (text/plain), 3.72 KB, created by Yusuke Suzuki on 2018-05-14 08:36:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2018-05-14 08:36:07 PDT

Size: 3.72 KB

patch

obsolete

>Subversion Revision: 231757
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 5f404d99413b3f971da8bbc3e0aaa7fff03ed4fa..d00e4373297aaf9dd513f35e87fe9216158478b9 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        [JSC][LLInt] Use bt for comparison using zero
>+        https://bugs.webkit.org/show_bug.cgi?id=185613
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use branchTest (bt) instructions for comparison with zero.
>+
>+        * llint/LowLevelInterpreter.asm:
>+        * llint/LowLevelInterpreter32_64.asm:
>+        * llint/LowLevelInterpreter64.asm:
>+
> 2018-05-14  Dominik Infuehr  <dinfuehr@igalia.com>
> 
>         [MIPS] Use btpz to compare against 0 instead of bpeq
>diff --git a/Source/JavaScriptCore/llint/LowLevelInterpreter.asm b/Source/JavaScriptCore/llint/LowLevelInterpreter.asm
>index 2bc9febfec38578267c060c9f638cb1185581cda..16fac61b116fcbebd80299c54480b4f58d9f652f 100644
>--- a/Source/JavaScriptCore/llint/LowLevelInterpreter.asm
>+++ b/Source/JavaScriptCore/llint/LowLevelInterpreter.asm
>@@ -1074,7 +1074,7 @@ macro prologue(codeBlockGetter, codeBlockSetter, osrSlowPath, traceSlowPath)
>     # Set up temporary stack pointer for call including callee saves
>     subp maxFrameExtentForSlowPathCall, sp
>     callSlowPath(_llint_stack_check)
>-    bpeq r1, 0, .stackHeightOKGetCodeBlock
>+    btpz r1, .stackHeightOKGetCodeBlock
>     move r1, cfr
>     dispatch(0) # Go to exception handler in PC
> 
>diff --git a/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm b/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
>index d51b6d14c00fad68d84770f3c03beb88646f2791..bb154718577ce3d190a02fc5bfb29e3ca3e4104a 100644
>--- a/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
>+++ b/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
>@@ -163,7 +163,7 @@ macro doVMEntry(makeCall)
>         move entry, t4
>         move vm, t5
>         cloopCallSlowPath _llint_stack_check_at_vm_entry, vm, t3
>-        bpeq t0, 0, .stackCheckFailed
>+        btpz t0, .stackCheckFailed
>         move t4, entry
>         move t5, vm
>         jmp .stackHeightOK
>@@ -2060,7 +2060,7 @@ _llint_op_catch:
>     loadi VM::targetInterpreterPCForThrow[t3], PC
> 
>     callSlowPath(_llint_slow_path_check_if_exception_is_uncatchable_and_notify_profiler)
>-    bpeq r1, 0, .isCatchableException
>+    btpz r1, .isCatchableException
>     jmp _llint_throw_from_slow_path_trampoline
> 
> .isCatchableException:
>@@ -2633,7 +2633,7 @@ _llint_op_profile_control_flow:
>     loadpFromInstruction(1, t0)
>     loadi BasicBlockLocation::m_executionCount[t0], t1
>     addi 1, t1
>-    bieq t1, 0, .done # We overflowed.
>+    btiz t1, .done # We overflowed.
>     storei t1, BasicBlockLocation::m_executionCount[t0]
> .done:
>     dispatch(2)
>diff --git a/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm b/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
>index 626989d526faeb02a85b20e95d6dcb968abb0ad0..cc5fa9acff8a44ce9aab7332e7f96bb1d7d46928 100644
>--- a/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
>+++ b/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
>@@ -152,7 +152,7 @@ macro doVMEntry(makeCall)
>         move entry, t4
>         move vm, t5
>         cloopCallSlowPath _llint_stack_check_at_vm_entry, vm, t3
>-        bpeq t0, 0, .stackCheckFailed
>+        btpz t0, .stackCheckFailed
>         move t4, entry
>         move t5, vm
>         jmp .stackHeightOK
>@@ -2113,7 +2113,7 @@ _llint_op_catch:
>     rshiftp 3, PC
> 
>     callSlowPath(_llint_slow_path_check_if_exception_is_uncatchable_and_notify_profiler)
>-    bpeq r1, 0, .isCatchableException
>+    btpz r1, .isCatchableException
>     jmp _llint_throw_from_slow_path_trampoline
> 
> .isCatchableException:

Flags:

saam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185613: 340320