Attachment 340297 Details for Bug 185603 – ROLLOUT of r219515

[patch] ROLLOUT of r219515

bug-185603-20180514033127.patch (text/plain), 1.57 KB, created by WebKit Commit Bot on 2018-05-14 00:31:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Commit Bot

Created: 2018-05-14 00:31:28 PDT

Size: 1.57 KB

patch

obsolete

>Subversion Revision: 231744
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index cf540aec2a73503bea3bb0d3d9ba349723b88337..193faa73cc562dfd31d98e34f602cae62733cbf2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-14  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r219515.
>+        https://bugs.webkit.org/show_bug.cgi?id=185603
>+
>+        It sometimes makes AudioUnitInitialize call to fail in
>+        CoreAudioCaptureSource (Requested by youenn on #webkit).
>+
>+        Reverted changeset:
>+
>+        "Remove CoreAudioCaptureSource speaker configuration"
>+        https://bugs.webkit.org/show_bug.cgi?id=174512
>+        https://trac.webkit.org/changeset/219515
>+
> 2018-05-13  Dirk Schulze  <krit@webkit.org>
> 
>         Implement SVGGeometryElement's isPointInFill and isPointInStroke
>diff --git a/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp b/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
>index d8ace8225cfc4906d7c3eb47c70b28e6e8491bcf..6c74407e15fdb16181ffa557c31e621c12f22a02 100644
>--- a/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
>+++ b/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
>@@ -307,7 +307,9 @@ OSStatus CoreAudioSharedUnit::setupAudioUnit()
>     if (err)
>         return err;
> 
>-    // For the moment we do not need to configure speaker proc as we are not providing any reference data.
>+    err = configureSpeakerProc();
>+    if (err)
>+        return err;
> 
>     err = AudioUnitInitialize(m_ioUnit);
>     if (err) {

Actions: View | Formatted Diff | Diff

Attachments on bug 185603: 340297