WebKit Bugzilla
Attachment 340289 Details for
Bug 185589
: [JSC] timeClip(-0) should produce +0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185589-20180514132435.patch (text/plain), 4.77 KB, created by
Yusuke Suzuki
on 2018-05-13 21:24:36 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Yusuke Suzuki
Created:
2018-05-13 21:24:36 PDT
Size:
4.77 KB
patch
obsolete
>Subversion Revision: 231744 >diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog >index 1f0fbb428e1f1fe7e80eb43284a53c851a314f1a..b2d7353a9c80668b1cdcf8757a9546391c1e8d6a 100644 >--- a/Source/WTF/ChangeLog >+++ b/Source/WTF/ChangeLog >@@ -1,3 +1,18 @@ >+2018-05-13 Yusuke Suzuki <utatane.tea@gmail.com> >+ >+ [JSC] timeClip(-0) should produce +0 >+ https://bugs.webkit.org/show_bug.cgi?id=185589 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ According to the spec[1], timeClip(-0) should produce +0. >+ We achieve this by adding 0.0 to the result of trunc(t). >+ >+ [1]: https://tc39.github.io/ecma262/#sec-timeclip >+ >+ * wtf/DateMath.cpp: >+ (WTF::timeClip): >+ > 2018-05-13 Filip Pizlo <fpizlo@apple.com> > > Disable pointer poisoning >diff --git a/Source/WTF/wtf/DateMath.cpp b/Source/WTF/wtf/DateMath.cpp >index 6db92ebb2ae7dc92906a4b857d1411dc96e95b05..aaa5b7e6867909d7876d27419878a2b6d73e6fb5 100644 >--- a/Source/WTF/wtf/DateMath.cpp >+++ b/Source/WTF/wtf/DateMath.cpp >@@ -1159,7 +1159,7 @@ double timeClip(double t) > return std::numeric_limits<double>::quiet_NaN(); > if (fabs(t) > maxECMAScriptTime) > return std::numeric_limits<double>::quiet_NaN(); >- return trunc(t); >+ return trunc(t) + 0.0; > } > > // See http://tools.ietf.org/html/rfc2822#section-3.3 for more information. >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index 2ce1d0a52ca71d966faed23858b0e5627ecb2fe6..3e2c10239342db2e18b7957ae89cfa6f7f0d50d6 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,12 @@ >+2018-05-13 Yusuke Suzuki <utatane.tea@gmail.com> >+ >+ [JSC] timeClip(-0) should produce +0 >+ https://bugs.webkit.org/show_bug.cgi?id=185589 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt: >+ > 2018-05-13 Andy VanWagoner <andy@vanwagoner.family> > > [INTL] Improve spec & test262 compliance for Intl APIs >diff --git a/LayoutTests/sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt b/LayoutTests/sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt >index f929fda5fa8981b71d90ba2f88cf7d761596d77e..31ebfab53aa23e7645795faa3704a448934f4721 100644 >--- a/LayoutTests/sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt >+++ b/LayoutTests/sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt >@@ -1,6 +1,6 @@ > S15.9.1.14_D1 > >-#1: TimeClip returns (ToInteger(value)) >+#1: TimeClip returns (ToInteger(value) + (+0)) > PASS > > TEST COMPLETE >diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog >index fbf7d3f8fa806741f6a32eda2db143c4513f6c1b..3ce19e3ee9623a25b795afe9f653c34cb11cd3a6 100644 >--- a/JSTests/ChangeLog >+++ b/JSTests/ChangeLog >@@ -1,3 +1,14 @@ >+2018-05-13 Yusuke Suzuki <utatane.tea@gmail.com> >+ >+ [JSC] timeClip(-0) should produce +0 >+ https://bugs.webkit.org/show_bug.cgi?id=185589 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Fix several test262 failures. >+ >+ * test262/expectations.yaml: >+ > 2018-05-13 Caio Lima <ticaiolima@gmail.com> > > [BigInt] stress/big-int-spec-to-primitive.js test is failing >diff --git a/JSTests/test262/expectations.yaml b/JSTests/test262/expectations.yaml >index ff3bd3862614a21aed5e9f7790a39ce8bf086ac6..24b95f693fe0b87127016de59add98c0c4e96ebb 100644 >--- a/JSTests/test262/expectations.yaml >+++ b/JSTests/test262/expectations.yaml >@@ -958,9 +958,6 @@ test/built-ins/DataView/prototype/setUint8/detached-buffer-before-outofrange-byt > test/built-ins/DataView/prototype/setUint8/detached-buffer.js: > default: 'Test262Error: Expected a TypeError but got a RangeError' > strict mode: 'Test262Error: Expected a TypeError but got a RangeError' >-test/built-ins/Date/TimeClip_negative_zero.js: >- default: 'Test262Error: TimeClip does not return negative zero Expected SameValue(ë0û, ë0û) to be true' >- strict mode: 'Test262Error: TimeClip does not return negative zero Expected SameValue(ë0û, ë0û) to be true' > test/built-ins/Date/UTC/return-value.js: > default: 'Test262Error: 1970 Expected SameValue(ëNaNû, ë0û) to be true' > strict mode: 'Test262Error: 1970 Expected SameValue(ëNaNû, ë0û) to be true' >@@ -973,9 +970,6 @@ test/built-ins/Date/proto-from-ctor-realm-two.js: > test/built-ins/Date/proto-from-ctor-realm-zero.js: > default: 'TypeError: Type error' > strict mode: 'TypeError: Type error' >-test/built-ins/Date/prototype/getTime/this-value-valid-date.js: >- default: 'Test262Error: -0 Expected SameValue(ë0û, ë0û) to be true' >- strict mode: 'Test262Error: -0 Expected SameValue(ë0û, ë0û) to be true' > test/built-ins/Error/proto-from-ctor-realm.js: > default: 'Test262Error: Expected SameValue(ëErrorû, ëErrorû) to be true' > strict mode: 'Test262Error: Expected SameValue(ëErrorû, ëErrorû) to be true'
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
saam
:
review+
ews-watchlist
:
commit-queue-
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185589
:
340272
|
340273
|
340274
|
340275
|
340276
|
340277
| 340289 |
340293