Attachment 340268 Details for Bug 185586 – the patch

[patch] the patch

blah.patch (text/plain), 1.30 KB, created by Filip Pizlo on 2018-05-13 11:03:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Filip Pizlo

Created: 2018-05-13 11:03:24 PDT

Size: 1.30 KB

patch

obsolete

>Index: Source/WTF/ChangeLog
>===================================================================
>--- Source/WTF/ChangeLog	(revision 231741)
>+++ Source/WTF/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-05-13  Filip Pizlo  <fpizlo@apple.com>
>+
>+        Disable pointer poisoning
>+        https://bugs.webkit.org/show_bug.cgi?id=185586
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        This seems like a 0.3% speed-up on microbenchmarks. It seems like it may be a small speed-up on
>+        other tests, too.
>+
>+        * wtf/Platform.h:
>+
> 2018-05-11  Chris Dumez  <cdumez@apple.com>
> 
>         REGRESSION (async policy delegate): Revoking an object URL immediately after triggering download breaks file download
>Index: Source/WTF/wtf/Platform.h
>===================================================================
>--- Source/WTF/wtf/Platform.h	(revision 231686)
>+++ Source/WTF/wtf/Platform.h	(working copy)
>@@ -991,12 +991,7 @@
> #define ENABLE_SIGNAL_BASED_VM_TRAPS 1
> #endif
> 
>-#define ENABLE_POISON 1
>-/* Not currently supported for 32-bit or OS(WINDOWS) builds (because of missing llint support). Make sure it's disabled. */
>-#if USE(JSVALUE32_64) || OS(WINDOWS)
>-#undef ENABLE_POISON
> #define ENABLE_POISON 0
>-#endif
> 
> #if !defined(USE_POINTER_PROFILING) || USE(JSVALUE32_64) || !ENABLE(JIT)
> #undef USE_POINTER_PROFILING

Flags:

ysuzuki: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185586: 340268