Attachment 340235 Details for Bug 185571 – Patch

[patch] Patch

bug-185571-20180511173257.patch (text/plain), 1.15 KB, created by BJ Burg on 2018-05-11 17:32:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: BJ Burg

Created: 2018-05-11 17:32:57 PDT

Size: 1.15 KB

patch

obsolete

>Subversion Revision: 231727
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index bf6def710a0abaadfc9e8fd2ebf3240eb7f58bd1..7239f0d7f66d1c5373de37353623daaf928b88b3 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-05-11  Brian Burg  <bburg@apple.com>
>+
>+        Web Automation: Automation.getBrowsingContext returns window origin that differs from window.screenX/Y
>+        https://bugs.webkit.org/show_bug.cgi?id=185571
>+        <rdar://problem/40180785>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This code path was refactored to use completion handlers. It seems that the window.screenX/Y
>+        code path converts back to user coordinates but the WebDriver code path does not. Make them
>+        consistent since that is how it is spec'd and tested.
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::getWindowFrameWithCallback):
>+        Convert the window frame to user coordinate space so it's the same as window.screenY.
>+
> 2018-05-11  Megan Gardner  <megan_gardner@apple.com>
> 
>         Cleanup canPerformActionForWebView in relation to the webSelectionAssistant being removed

Actions: View | Formatted Diff | Diff

Attachments on bug 185571: 340235 | 340352