Attachment 340234 Details for Bug 185570 – Patch

[patch] Patch

bug-185570-20180511171124.patch (text/plain), 1.97 KB, created by dewei_zhu on 2018-05-11 17:11:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: dewei_zhu

Created: 2018-05-11 17:11:25 PDT

Size: 1.97 KB

patch

obsolete

>Subversion Revision: 231727
>diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
>index bd5b024c043e92c77a2c547c465905c914e7c5de..7e2cd0100f5fe49ba67a1993549f0e227636e0b8 100644
>--- a/Websites/perf.webkit.org/ChangeLog
>+++ b/Websites/perf.webkit.org/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-11  Dewei Zhu  <dewei_zhu@apple.com>
>+
>+        Update ChartPane per change r231087.
>+        https://bugs.webkit.org/show_bug.cgi?id=185570
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        On r231087 we change the return type of AnalysisTask.create, ChartPane needs to adapt
>+        this change.
>+
>+        * public/v3/pages/chart-pane.js: Adapted the change that AnalysisTask.create now returns
>+        an AnalysisTask object.
>+        (ChartPane.prototype.async._analyzeRange):
>+
> 2018-05-10  Dewei Zhu  <dewei_zhu@apple.com>
> 
>         CommitLogViewer._preceedingCommit should not always be null
>diff --git a/Websites/perf.webkit.org/public/v3/pages/chart-pane.js b/Websites/perf.webkit.org/public/v3/pages/chart-pane.js
>index 5fc172fd24824722f755e2a23f8889f6e5a4a143..8cd7aa0047f7adfccd6bff404f874ce137fe3070 100644
>--- a/Websites/perf.webkit.org/public/v3/pages/chart-pane.js
>+++ b/Websites/perf.webkit.org/public/v3/pages/chart-pane.js
>@@ -239,9 +239,9 @@ class ChartPane extends ChartPaneBase {
>         const repetitionCount = this.content('confirm-repetition').value;
> 
>         try {
>-            const data = await (createWithTestGroup ?
>+            const analysisTask = await (createWithTestGroup ?
>                 AnalysisTask.create(name, startPoint, endPoint, 'Confirm', repetitionCount) : AnalysisTask.create(name, startPoint, endPoint));
>-            newWindow.location.href = router.url('analysis/task/' + data['taskId']);
>+            newWindow.location.href = router.url('analysis/task/' + analysisTask.id());
>             this.fetchAnalysisTasks(true);
>         } catch(error) {
>             newWindow.location.href = router.url('analysis/task/create', {error: error});

Flags:

rniwa: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185570: 340234