Attachment 340224 Details for Bug 185532 – Patch

[patch] Patch

bug-185532-20180511145030.patch (text/plain), 1.73 KB, created by Brady Eidson on 2018-05-11 14:50:31 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brady Eidson

Created: 2018-05-11 14:50:31 PDT

Size: 1.73 KB

patch

obsolete

>Subversion Revision: 231710
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 5b571af803bdf2567dada42251f211cb56b8302b..566c60019b918a4860a1bffa3a7d90b7013f160e 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-05-11  Brady Eidson  <beidson@apple.com>
>+
>+        Followup to: Make sure history navigations reuse the existing process when necessary.
>+        https://bugs.webkit.org/show_bug.cgi?id=185532
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/WebProcessPool.cpp:
>+        (WebKit::WebProcessPool::processForNavigationInternal): When re-using the same process,
>+          don't change the policy action.
>+
> 2018-05-11  Charles Vazac  <cvazac@gmail.com>
> 
>         Runtime feature flag for Server-Timing
>diff --git a/Source/WebKit/UIProcess/WebProcessPool.cpp b/Source/WebKit/UIProcess/WebProcessPool.cpp
>index ebdd04570609f333121721d16f7466f9c523e79e..a73cecd6514c96ee13b6c1c5e1dc537ec81f3cd0 100644
>--- a/Source/WebKit/UIProcess/WebProcessPool.cpp
>+++ b/Source/WebKit/UIProcess/WebProcessPool.cpp
>@@ -2112,10 +2112,8 @@ Ref<WebProcessProxy> WebProcessPool::processForNavigationInternal(WebPageProxy&
>         // If the target back/forward item and the current back/forward item originated
>         // in the same WebProcess then we should reuse the current WebProcess.
>         if (auto* currentItem = page.backForwardList().currentItem()) {
>-            if (currentItem->itemID().processIdentifier == backForwardListItem->itemID().processIdentifier) {
>-                action = PolicyAction::Suspend;
>+            if (currentItem->itemID().processIdentifier == backForwardListItem->itemID().processIdentifier)
>                 return page.process();
>-            }
>         }
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185532: 340140 | 340151 | 340224