Attachment 340210 Details for Bug 185555 – Patch

[patch] Patch

bug-185555-20180511135000.patch (text/plain), 1.43 KB, created by Michael Catanzaro on 2018-05-11 11:50:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2018-05-11 11:50:01 PDT

Size: 1.43 KB

patch

obsolete

>Subversion Revision: 231704
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index dfff45a14e143c2e050de3eedf16d5e06db12442..52a58977435959e94ceb5774793b0207148ff972 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-11  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        -Wmemset-elt-size warning in LibWebRTCSocket constructor
>+        https://bugs.webkit.org/show_bug.cgi?id=185555
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add missing multiplication.
>+
>+        * WebProcess/Network/webrtc/LibWebRTCSocket.cpp:
>+        (WebKit::LibWebRTCSocket::LibWebRTCSocket):
>+
> 2018-05-11  Brady Eidson  <beidson@apple.com>
> 
>         Make sure history navigations reuse the existing process when necessary.
>diff --git a/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp b/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp
>index c3014537093c46421fa6ed899768d0a0a342e0a6..3492b191e780c488eedf6c353c57b6fc7e2f2adc 100644
>--- a/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp
>+++ b/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp
>@@ -54,7 +54,7 @@ LibWebRTCSocket::LibWebRTCSocket(LibWebRTCSocketFactory& factory, uint64_t ident
>     , m_localAddress(localAddress)
>     , m_remoteAddress(remoteAddress)
> {
>-    memset(&m_options, 1, MAX_SOCKET_OPTION);
>+    memset(&m_options, 1, MAX_SOCKET_OPTION * sizeof(m_options[0]));
> }
> 
> LibWebRTCSocket::~LibWebRTCSocket()

Actions: View | Formatted Diff | Diff

Attachments on bug 185555: 340210 | 340651 | 340671