Attachment 340198 Details for Bug 185552 – Proposed fix

[patch] Proposed fix

bug-185552-20180511103425.patch (text/plain), 1.45 KB, created by BJ Burg on 2018-05-11 10:34:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: BJ Burg

Created: 2018-05-11 10:34:26 PDT

Size: 1.45 KB

patch

obsolete

>Subversion Revision: 231661
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 73ea77bcf106b446328624db550349b2aceafc04..2b2e64f2f7e32032e5a1f686abbe5bc0fc3ca4ef 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-11  Brian Burg  <bburg@apple.com>
>+
>+        Web Automation: disable process swap on navigation when an automation session is active
>+        https://bugs.webkit.org/show_bug.cgi?id=185552
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/WebProcessPool.cpp:
>+        (WebKit::WebProcessPool::processForNavigationInternal):
>+        This is not intended to work right now. Opt out to avoid crashing
>+        later when a process is deallocated unexpectedly.
>+
> 2018-05-10  Chris Dumez  <cdumez@apple.com>
> 
>         'Cross-Origin-Options header implementation follow-up
>diff --git a/Source/WebKit/UIProcess/WebProcessPool.cpp b/Source/WebKit/UIProcess/WebProcessPool.cpp
>index 11cc8bd5c2ceaf5132c1bfa498e8fa9129e620b3..708ba1be246c628febec034db8c15a5add9e79ae 100644
>--- a/Source/WebKit/UIProcess/WebProcessPool.cpp
>+++ b/Source/WebKit/UIProcess/WebProcessPool.cpp
>@@ -2085,6 +2085,9 @@ Ref<WebProcessProxy> WebProcessPool::processForNavigationInternal(WebPageProxy&
>     if (page.inspectorFrontendCount() > 0)
>         return page.process();
> 
>+    if (m_automationSession)
>+        return page.process();
>+
>     if (!page.process().hasCommittedAnyProvisionalLoads())
>         return page.process();
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185552: 340198