Attachment 340179 Details for Bug 185543 – Patch

[patch] Patch

bug-185543-20180511101947.patch (text/plain), 2.71 KB, created by youenn fablet on 2018-05-11 01:19:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-05-11 01:19:48 PDT

Size: 2.71 KB

patch

obsolete

>Subversion Revision: 231552
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 9743edfc52e68f82f7a9a81b46ad49d2b8dbdf85..7263efdae78d63298f21db37ef5d8df73916bd89 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-11  Youenn Fablet  <youenn@apple.com>
>+
>+        http/tests/appcache/deferred-events.html is flaky due to console log messages
>+        https://bugs.webkit.org/show_bug.cgi?id=185543
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Update the test to wait for the onerror callback.
>+        At that time, all console logging should be done.
>+
>+        * http/tests/appcache/deferred-events-expected.txt:
>+        * http/tests/appcache/deferred-events.html:
>+
> 2018-05-11  Youenn Fablet  <youenn@apple.com>
> 
>         Skip http/tests/appcache/load-from-appcache-defer-resume-crash.html for iOS sim WK2
>diff --git a/LayoutTests/http/tests/appcache/deferred-events-expected.txt b/LayoutTests/http/tests/appcache/deferred-events-expected.txt
>index 9332764c9c82014861a0ee3c5d9ede3a35b16607..5989a818372b1aa028f09639a5a661dceea2cd9c 100644
>--- a/LayoutTests/http/tests/appcache/deferred-events-expected.txt
>+++ b/LayoutTests/http/tests/appcache/deferred-events-expected.txt
>@@ -1,4 +1,4 @@
> CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
> CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
> Test that AppicationCache events are deferred until after onload has been fired.
>-SUCCESS
>+PASS
>diff --git a/LayoutTests/http/tests/appcache/deferred-events.html b/LayoutTests/http/tests/appcache/deferred-events.html
>index 1a822fc78fc320e110c276885d537446f13e30b2..289fbe3fc4c5662490f916f2a8725e8766180e66 100644
>--- a/LayoutTests/http/tests/appcache/deferred-events.html
>+++ b/LayoutTests/http/tests/appcache/deferred-events.html
>@@ -2,6 +2,7 @@
> <head>
>   <script type="text/javascript">
>     var onloadHasBeenCalled = false;
>+    var oncheckingAfterOnload = false;
> 
>     if (window.testRunner) {
>         testRunner.dumpAsText()
>@@ -9,8 +10,17 @@
>     }
> 
>     window.applicationCache.onchecking = function() {
>-        if (onloadHasBeenCalled)
>-            document.getElementById('result').innerHTML = "SUCCESS"
>+        oncheckingAfterOnload = onloadHasBeenCalled;
>+    }
>+
>+    window.applicationCache.onerror = function() {
>+        document.getElementById('result').innerHTML = oncheckingAfterOnload ? "PASS" : "FAIL";
>+        if (window.testRunner)
>+            testRunner.notifyDone();
>+    }
>+
>+    window.applicationCache.oncached = function() {
>+        document.getElementById('result').innerHTML = "FAIL: oncached event received";
>         if (window.testRunner)
>             testRunner.notifyDone();
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 185543: 340179