WebKit Bugzilla
Attachment 340175 Details for
Bug 185384
: Layout Test webrtc/addICECandidate-closed.html is a flaky failure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185384-20180511084852.patch (text/plain), 2.34 KB, created by
youenn fablet
on 2018-05-10 23:48:54 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
youenn fablet
Created:
2018-05-10 23:48:54 PDT
Size:
2.34 KB
patch
obsolete
>Subversion Revision: 231552 >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index c5004e0c79e01d9ade444a07c52a7d0b4f8d8aee..d7205997b5b15686af9bfc119fcc0b4dce8089a5 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,14 @@ >+2018-05-10 Youenn Fablet <youenn@apple.com> >+ >+ Layout Test webrtc/addICECandidate-closed.html is a flaky failure >+ https://bugs.webkit.org/show_bug.cgi?id=185384 >+ <rdar://problem/40035167> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * webrtc/addICECandidate-closed.html: Move more pc calls inside the try/catch. >+ This ensures that the test will be consistent as the pc might be closed sooner for some runs. >+ > 2018-05-09 Youenn Fablet <youenn@apple.com> > > LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404.html is flaky >diff --git a/LayoutTests/webrtc/addICECandidate-closed.html b/LayoutTests/webrtc/addICECandidate-closed.html >index d4bfc77017b23cd6ed85d459107d4080c0eeb81c..39eef0316e416962e9a3e9d84b01b750adeb8ddb 100644 >--- a/LayoutTests/webrtc/addICECandidate-closed.html >+++ b/LayoutTests/webrtc/addICECandidate-closed.html >@@ -25,15 +25,15 @@ promise_test(async (test) => { > localTracks.forEach(track => sender.addTrack(track, stream)); > receiver.addTransceiver('audio'); > receiver.addTransceiver('video'); >- const offer1 = await sender.createOffer(); >- await sender.setLocalDescription(offer1); >- await receiver.setRemoteDescription(offer1); >- const answer1 = await receiver.createAnswer(); >- await receiver.setLocalDescription(answer1); > await new Promise (async (resolve) => { > // RTCPeerConnection does not resolve promises when it gets closed, hence the timeout here to make sure we execute some if not all these operations. > test.step_timeout(resolve, 100); > try { >+ const offer1 = await sender.createOffer(); >+ await sender.setLocalDescription(offer1); >+ await receiver.setRemoteDescription(offer1); >+ const answer1 = await receiver.createAnswer(); >+ await receiver.setLocalDescription(answer1); > await sender.setRemoteDescription(answer1); > const offer2 = await sender.createOffer(); > await sender.setLocalDescription(offer2);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185384
:
339733
|
340175
|
340187
|
340465