Attachment 340171 Details for Bug 185540 – Patch

[patch] Patch

bug-185540-20180510222726.patch (text/plain), 2.85 KB, created by dewei_zhu on 2018-05-10 22:27:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: dewei_zhu

Created: 2018-05-10 22:27:26 PDT

Size: 2.85 KB

patch

obsolete

>Subversion Revision: 231689
>diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
>index 36e18f62e75ba505a31cb5d0edc1e1b036222428..962c46717488d42c8929ef6b7ffd476723655d98 100644
>--- a/Websites/perf.webkit.org/ChangeLog
>+++ b/Websites/perf.webkit.org/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-10  Dewei Zhu  <dewei_zhu@apple.com>
>+
>+        CommitLogViewer._preceedingCommit should not always be null
>+        https://bugs.webkit.org/show_bug.cgi?id=185540
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix the bug introduced in r227746 that CommitLogViewer._preceedingCommit is always null.
>+
>+        * browser-tests/index.html: Fix expected measurement-set url.
>+        * public/v3/components/commit-log-viewer.js: 
>+        (CommitLogViewer.prototype._fetchCommitLogs): CommitLogViewer._preceedingCommit should be set
>+         when fetching for preceeding revision succeeds.
>+
> 2018-05-03  Dewei Zhu  <dewei_zhu@apple.com>
> 
>         Range bisector should check the commits for repositories without change in specified range.
>diff --git a/Websites/perf.webkit.org/browser-tests/index.html b/Websites/perf.webkit.org/browser-tests/index.html
>index 517ae851ed6d78e7523e65b6e39e4d6c5d210a56..dded1790503422541ea90343244a33baa8906450 100644
>--- a/Websites/perf.webkit.org/browser-tests/index.html
>+++ b/Websites/perf.webkit.org/browser-tests/index.html
>@@ -363,7 +363,7 @@ const ChartTest = {
> 
>     respondWithSampleCluster(request, options)
>     {
>-        expect(request.url).to.be('../data/measurement-set-1-1.json');
>+        expect(request.url).to.be('/data/measurement-set-1-1.json');
>         expect(request.method).to.be('GET');
>         request.resolve(this.makeSampleCluster(options));
>     },
>diff --git a/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js b/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js
>index 005b552fa56b6dacd3d90fb363bf9ea3262b0b7b..7a8e3b93e82c9db4f241f7fd0102e2e8d0f22cf8 100644
>--- a/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js
>+++ b/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js
>@@ -36,7 +36,6 @@ class CommitLogViewer extends ComponentBase {
>         }
> 
>         let promise;
>-        let precedingCommitPromise;
>         const fetchSingleCommit = !precedingRevision || precedingRevision == lastRevision;
>         if (fetchSingleCommit) {
>             promise = CommitLog.fetchForSingleRevision(repository, lastRevision).then((commits) => {
>@@ -55,7 +54,7 @@ class CommitLogViewer extends ComponentBase {
>                 CommitLog.fetchForSingleRevision(repository, precedingRevision).then((precedingCommit) => {
>                     if (this._fetchingPromise != promise)
>                         return;
>-                    this._precedingCommit = null;
>+                    this._precedingCommit = precedingCommit[0];
>                 })
>             ]);
>         }

Flags:

rniwa: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185540: 340171