Attachment 340165 Details for Bug 182589 – Speculative fix

[patch] Speculative fix

bug-182589-20180510204502.patch (text/plain), 2.37 KB, created by Ryosuke Niwa on 2018-05-10 20:45:02 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2018-05-10 20:45:02 PDT

Size: 2.37 KB

patch

obsolete

>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 231686)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        REGRESSION(r227983): fast/dom/adopt-node-crash-2.html is flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=182589
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This is a speculative fix for the test since I can't reproduce the flakiness locally. Because r227983 makes
>+        the layout update async, I suspect the focus change which occurs to the keygen having autofocus attribute
>+        isn't updating the layout in time for notifyDone call. Manually update the layout before/after the test.
>+
>+        Also wait for the load event to figure before starting the test since layout, etc... may not be updated
>+        immediately after DOMContentLoaded.
>+
>+        * fast/dom/adopt-node-crash-2.html:
>+
> 2018-05-10  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [Extra zoom mode] fast/visual-viewport/extrazoom/layout-viewport-after-scrolling-and-resizing.html sometimes fails
>Index: LayoutTests/fast/dom/adopt-node-crash-2.html
>===================================================================
>--- LayoutTests/fast/dom/adopt-node-crash-2.html	(revision 231686)
>+++ LayoutTests/fast/dom/adopt-node-crash-2.html	(working copy)
>@@ -20,13 +20,23 @@ if (window.testRunner) {
> <script>
> function doit()
> {
>-    div2.addEventListener("DOMFocusOut", function () { document.implementation.createDocument("", "", null).adoptNode(div2); }, false);
>+    div2.addEventListener("DOMFocusOut", function () {
>+        document.implementation.createDocument("", "", null).adoptNode(div2);
>+        setTimeout(() => {
>+            if (window.internals)
>+                internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks();
>+            if (window.testRunner)
>+                testRunner.notifyDone();
>+        }, 0);
>+    }, false);
>     div1.outerHTML = header1.outerHTML;
>-    if (window.testRunner)
>-        testRunner.notifyDone();
> }
>-document.addEventListener("DOMContentLoaded", function() {
>+window.onload = function() {
>+    if (window.internals)
>+        internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks();
>+    else
>+        div2.getBoundingClientRect();
>     setTimeout("doit()", 1);
>-}, false);
>+}
> </script>
> </html>

Flags:

wenson_hsieh: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 182589: 340165