Attachment 340143 Details for Bug 185533 – Fixes the bug

[patch] Fixes the bug

bug-185533-20180510161246.patch (text/plain), 1.18 KB, created by Ryosuke Niwa on 2018-05-10 16:12:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2018-05-10 16:12:47 PDT

Size: 1.18 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 231670)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        build-webkit can erroneously warn about Xcode being too old
>+        https://bugs.webkit.org/show_bug.cgi?id=185533
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Don't assume the version number is always a single digit.
>+
>+        * Scripts/webkitdirs.pm:
>+        (determineXcodeVersion):
>+
> 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         Fix some -Wstring-op-truncation warnings
>Index: Tools/Scripts/webkitdirs.pm
>===================================================================
>--- Tools/Scripts/webkitdirs.pm	(revision 231654)
>+++ Tools/Scripts/webkitdirs.pm	(working copy)
>@@ -230,7 +230,7 @@ sub determineXcodeVersion
> {
>     return if defined $xcodeVersion;
>     my $xcodebuildVersionOutput = `xcodebuild -version`;
>-    $xcodeVersion = ($xcodebuildVersionOutput =~ /Xcode ([0-9](\.[0-9]+)*)/) ? $1 : "3.0";
>+    $xcodeVersion = ($xcodebuildVersionOutput =~ /Xcode ([0-9]+(\.[0-9]+)*)/) ? $1 : "3.0";
> }
> 
> sub readXcodeUserDefault($)

Actions: View | Formatted Diff | Diff

Attachments on bug 185533: 340143