Attachment 340129 Details for Bug 185529 – Patch

[patch] Patch

bug-185529-20180510141554.patch (text/plain), 4.38 KB, created by Megan Gardner on 2018-05-10 14:15:55 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2018-05-10 14:15:55 PDT

Size: 4.38 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 231659)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,20 @@
>+2018-05-10  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Remove Unused Chinese/Japanese Reanalyze code
>+        https://bugs.webkit.org/show_bug.cgi?id=185529
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        The code for this has actually been completely removed from UIKit. This is unreachable 
>+        dead code that should be removed if just for cleanliness. 
>+
>+        * Platform/spi/ios/UIKitSPI.h:
>+        * UIProcess/API/Cocoa/WKWebViewInternal.h:
>+        * UIProcess/ios/WKContentViewInteraction.h:
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView canPerformActionForWebView:withSender:]):
>+        (-[WKContentView _reanalyzeForWebView:]): Deleted.
>+
> 2018-05-10  Chris Dumez  <cdumez@apple.com>
> 
>         'Cross-Origin-Options header implementation follow-up
>Index: Source/WebKit/Platform/spi/ios/UIKitSPI.h
>===================================================================
>--- Source/WebKit/Platform/spi/ios/UIKitSPI.h	(revision 231598)
>+++ Source/WebKit/Platform/spi/ios/UIKitSPI.h	(working copy)
>@@ -1015,7 +1015,6 @@ WTF_EXTERN_C_BEGIN
> 
> BOOL UIKeyboardEnabledInputModesAllowOneToManyShortcuts(void);
> BOOL UIKeyboardEnabledInputModesAllowChineseTransliterationForText(NSString *);
>-BOOL UIKeyboardCurrentInputModeAllowsChineseOrJapaneseReanalysisForText(NSString *);
> 
> extern const float UITableCellDefaultFontSize;
> extern const float UITableViewCellDefaultFontSize;
>Index: Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h	(revision 231598)
>+++ Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h	(working copy)
>@@ -129,7 +129,6 @@ struct PrintInfo;
> - (void)_arrowKey:(id)sender;
> - (void)_define:(id)sender;
> - (void)_lookup:(id)sender;
>-- (void)_reanalyze:(id)sender;
> - (void)_share:(id)sender;
> - (void)_showTextStyleOptions:(id)sender;
> - (void)_promptForReplace:(id)sender;
>Index: Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>===================================================================
>--- Source/WebKit/UIProcess/ios/WKContentViewInteraction.h	(revision 231598)
>+++ Source/WebKit/UIProcess/ios/WKContentViewInteraction.h	(working copy)
>@@ -108,7 +108,6 @@ typedef std::pair<WebKit::InteractionInf
>     M(_define) \
>     M(_lookup) \
>     M(_promptForReplace) \
>-    M(_reanalyze) \
>     M(_share) \
>     M(_showTextStyleOptions) \
>     M(_transliterateChinese) \
>Index: Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>===================================================================
>--- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(revision 231598)
>+++ Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(working copy)
>@@ -265,7 +265,6 @@ @interface UITextInteractionAssistant (U
> // FIXME: this needs to be moved from the internal header to the private.
> - (id)initWithView:(UIResponder <UITextInput> *)view;
> - (void)selectWord;
>-- (void)scheduleReanalysis;
> @end
> 
> @interface UIView (UIViewInternalHack)
>@@ -2154,11 +2153,6 @@ - (void)_transliterateChineseForWebView:
>     [_textSelectionAssistant scheduleChineseTransliterationForText:_page->editorState().postLayoutData().wordAtSelection];
> }
> 
>-- (void)_reanalyzeForWebView:(id)sender
>-{
>-    [_textSelectionAssistant scheduleReanalysis];
>-}
>-
> - (void)replaceForWebView:(id)sender
> {
>     [[UIKeyboardImpl sharedInstance] replaceText:sender];
>@@ -2311,12 +2305,6 @@         // acceptable, but the interface
>         return UIKeyboardEnabledInputModesAllowChineseTransliterationForText([self selectedText]);
>     }
> 
>-    if (action == @selector(_reanalyze:)) {
>-        if (!_page->editorState().selectionIsRange || !_page->editorState().postLayoutData().isReplaceAllowed || ![[UIKeyboardImpl activeInstance] autocorrectSpellingEnabled])
>-            return NO;
>-        return UIKeyboardCurrentInputModeAllowsChineseOrJapaneseReanalysisForText([self selectedText]);
>-    }
>-
>     if (action == @selector(select:)) {
>         // Disable select in password fields so that you can't see word boundaries.
>         return !_page->editorState().isInPasswordField && [self hasContent] && !_page->editorState().selectionIsNone && !_page->editorState().selectionIsRange;

Actions: View | Formatted Diff | Diff

Attachments on bug 185529: 340129