Attachment 340126 Details for Bug 185528 – Patch

[patch] Patch

bug-185528-20180510140139.patch (text/plain), 2.50 KB, created by Ross Kirsling on 2018-05-10 14:01:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ross Kirsling

Created: 2018-05-10 14:01:38 PDT

Size: 2.50 KB

patch

obsolete

>Subversion Revision: 231653
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 5e96c31d841dd4d9ae04fbf16970de5d2ab8a949..ea6f455cebd7eaeceec7282938379d3b8fccae88 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
>+
>+        [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
>+        https://bugs.webkit.org/show_bug.cgi?id=185528
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/build.webkit.org-config/factories.py:
>+        (TestFactory.__init__):
>+        * BuildSlaveSupport/build.webkit.org-config/steps.py:
>+        (InstallWinCairoDependencies):
>+
> 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
> 
>         Support --verbose in run-javascriptcore-tests
>diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py b/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py
>index 690e392e008a0853702782f83a46fbcdc08c2777..f8b733e316672f98c213a6d864bcb67e54f0c5a9 100644
>--- a/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py
>+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py
>@@ -80,6 +80,10 @@ class TestFactory(Factory):
>     def __init__(self, platform, configuration, architectures, additionalArguments=None, SVNMirror=None, **kwargs):
>         Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, SVNMirror, **kwargs)
>         self.getProduct()
>+
>+        if platform == 'wincairo':
>+            self.addStep(InstallWinCairoDependencies())
>+
>         if self.JSCTestClass:
>             self.addStep(self.JSCTestClass())
>         if self.LayoutTestClass:
>diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py b/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>index bfe7ed17813470124f2359d2f279c365682ac6f1..361610876724c3df40685db0263efb22d9e945a7 100644
>--- a/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>@@ -160,6 +160,14 @@ class DeleteStaleBuildFiles(shell.Compile):
>         return shell.Compile.start(self)
> 
> 
>+class InstallWinCairoDependencies(shell.ShellCommand):
>+    name = 'wincairo-requirements'
>+    description = ['updating wincairo dependencies']
>+    descriptionDone = ['updated wincairo dependencies']
>+    command = ['python', './Tools/Scripts/update-webkit-wincairo-libs.py']
>+    haltOnFailure = True
>+
>+
> class InstallGtkDependencies(shell.ShellCommand):
>     name = "jhbuild"
>     description = ["updating gtk dependencies"]

Actions: View | Formatted Diff | Diff

Attachments on bug 185528: 340126