Attachment 340123 Details for Bug 185527 – proposed fix

[patch] proposed fix

HiddenPlatform.txt (text/plain), 1.48 KB, created by Alexey Proskuryakov on 2018-05-10 13:42:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Proskuryakov

Created: 2018-05-10 13:42:25 PDT

Size: 1.48 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 231653)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2018-05-10  Alexey Proskuryakov  <ap@apple.com>
>+
>+        Exception in bot watcher's dashboard if a hidden platform in no longer configured for display
>+        https://bugs.webkit.org/show_bug.cgi?id=185527
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
>+        (updateHiddenPlatforms):
>+
> 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
> 
>         Support --verbose in run-javascriptcore-tests
>Index: Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js
>===================================================================
>--- Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js	(revision 231438)
>+++ Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js	(working copy)
>@@ -130,6 +130,8 @@ function updateHiddenPlatforms()
> 
>     for (var i = 0; i < hiddenPlatformFamilies.length; ++i) {
>         var platformFamily = hiddenPlatformFamilies[i];
>+        if (!(platformFamily in platformsByFamily))
>+            continue;
>         for (var j = 0; j < platformsByFamily[platformFamily].length; ++j) {
>             var name = platformsByFamily[platformFamily][j];
>             var platformRow = document.querySelector("tr.platform." + name);

Actions: View | Formatted Diff | Diff

Attachments on bug 185527: 340122 | 340123