Attachment 340098 Details for Bug 185492 – Updated patch with review comments

[patch] Updated patch with review comments

185492-2.diff (text/plain), 2.05 KB, created by Stephan Szabo on 2018-05-10 10:18:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Stephan Szabo

Created: 2018-05-10 10:18:46 PDT

Size: 2.05 KB

patch

obsolete

>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 77bb27188b7..42db82cc088 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-09  Stephan Szabo  <stephan.szabo@sony.com>
>+
>+        Support --verbose in run-javascriptcore-tests
>+        https://bugs.webkit.org/show_bug.cgi?id=185492
>+
>+        Reviewed by Daniel Bates.
>+
>+        * Scripts/run-javascriptcore-tests:
>+        (runJSCStressTests):
>+
> 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
> 
>         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
>diff --git a/Tools/Scripts/run-javascriptcore-tests b/Tools/Scripts/run-javascriptcore-tests
>index 75f16a47556..78df9633f8b 100755
>--- a/Tools/Scripts/run-javascriptcore-tests
>+++ b/Tools/Scripts/run-javascriptcore-tests
>@@ -93,6 +93,7 @@ my $failFast = 1;
> my %jsonData = ();
> my $remoteConfigFile;
> my $jsonFileName;
>+my $verbose = 0;
> 
> if ($ENV{RUN_JAVASCRIPTCORE_TESTS_TESTMASM}) {
>     if ($ENV{RUN_JAVASCRIPTCORE_TESTS_TESTMASM} eq "true") {
>@@ -231,6 +232,7 @@ Usage: $programName [options] [options to pass to build system]
>                                 Each environment variable should be separated by a space.
>                                 e.g. \"foo=bar x=y\" (no quotes).
>   --gmalloc:                    Run tests with Guard Malloc enabled (if no path is given: $gmallocDefaultPath is used)
>+  --verbose:                    Verbose output (specify more than once to increase verbosity).
> 
> Environment Variables:
>   - set RUN_JAVASCRIPTCORE_TESTS_TESTMASM to "true" or "false" (no quotes) to determine if we run testmasm by default.
>@@ -277,6 +279,7 @@ GetOptions(
>     'help' => \$showHelp,
>     'env-vars=s' => \$envVars,
>     'gmalloc:s' => \$gmallocPath,
>+    'verbose+' => \$verbose
> );
> 
> 
>@@ -517,6 +520,8 @@ sub runJSCStressTests
>         push(@jscStressDriverCmd, $filter);
>     }
> 
>+    push(@jscStressDriverCmd, ("--verbose") x $verbose) if ($verbose > 0);
>+
>     unshift @jscStressDriverCmd, wrapperPrefixIfNeeded() if shouldUseJhbuild();
> 
>     # End option processing, the rest of the arguments are tests

Actions: View | Formatted Diff | Diff

Attachments on bug 185492: 340033 | 340098