Attachment 340085 Details for Bug 185510 – [GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase

[patch] [GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase

GStreamer-Fix-style-issue-in-MediaPlayerPrivateGSt.patch (text/plain), 4.40 KB, created by Thibault Saunier on 2018-05-10 05:44:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thibault Saunier

Created: 2018-05-10 05:44:22 PDT

Size: 4.40 KB

patch

obsolete

>From b4aab3cf746b78b1ecd084d9f1e628eeac0fb215 Mon Sep 17 00:00:00 2001
>From: Thibault Saunier <tsaunier@igalia.com>
>Date: Thu, 10 May 2018 09:33:56 -0300
>Subject: [PATCH xserver] [GStreamer] Fix style issue in
> MediaPlayerPrivateGStreamerBase
>
>ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:629:  More than one command on the same line  [whitespace/newline] [4]
>ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:684:  More than one command on the same line  [whitespace/newline] [4]
>ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:807:  More than one command on the same line  [whitespace/newline] [4]
>
>https://bugs.webkit.org/show_bug.cgi?id=185510
>---
> Source/WebCore/ChangeLog                      | 20 +++++++++++++++++++
> .../MediaPlayerPrivateGStreamerBase.cpp       | 12 ++++++++---
> 2 files changed, 29 insertions(+), 3 deletions(-)
>
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 7bfeb4346a9..a034a0e7511 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-05-10  Thibault Saunier  <tsaunier@igalia.com>
>+
>+        [GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase
>+        https://bugs.webkit.org/show_bug.cgi?id=185510
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase
>+
>+        ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:629:  More than one command on the same line  [whitespace/newline] [4]
>+        ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:684:  More than one command on the same line  [whitespace/newline] [4]
>+        ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:807:  More than one command on the same line  [whitespace/newline] [4]
>+
>+        Indentation and style issue fixed only.
>+
>+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
>+        (WebCore::MediaPlayerPrivateGStreamerBase::volumeChangedCallback):
>+        (WebCore::MediaPlayerPrivateGStreamerBase::muteChangedCallback):
>+        (WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
>+
> 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
> 
>         [GStreamer] Never call updateTracks if running on legacy pipeline
>diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
>index 274f070b641..87472bc2e62 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
>@@ -615,7 +615,9 @@ void MediaPlayerPrivateGStreamerBase::volumeChangedCallback(MediaPlayerPrivateGS
>     // This is called when m_volumeElement receives the notify::volume signal.
>     GST_DEBUG_OBJECT(player->pipeline(), "Volume changed to: %f", player->volume());
> 
>-    player->m_notifier->notify(MainThreadNotification::VolumeChanged, [player] { player->notifyPlayerOfVolumeChange(); });
>+    player->m_notifier->notify(MainThreadNotification::VolumeChanged, [player] {
>+        player->notifyPlayerOfVolumeChange();
>+    });
> }
> 
> MediaPlayer::NetworkState MediaPlayerPrivateGStreamerBase::networkState() const
>@@ -670,7 +672,9 @@ void MediaPlayerPrivateGStreamerBase::notifyPlayerOfMute()
> void MediaPlayerPrivateGStreamerBase::muteChangedCallback(MediaPlayerPrivateGStreamerBase* player)
> {
>     // This is called when m_volumeElement receives the notify::mute signal.
>-    player->m_notifier->notify(MainThreadNotification::MuteChanged, [player] { player->notifyPlayerOfMute(); });
>+    player->m_notifier->notify(MainThreadNotification::MuteChanged, [player] {
>+        player->notifyPlayerOfMute();
>+    });
> }
> 
> void MediaPlayerPrivateGStreamerBase::acceleratedRenderingStateChanged()
>@@ -793,7 +797,9 @@ void MediaPlayerPrivateGStreamerBase::triggerRepaint(GstSample* sample)
> 
>     if (triggerResize) {
>         GST_DEBUG_OBJECT(pipeline(), "First sample reached the sink, triggering video dimensions update");
>-        m_notifier->notify(MainThreadNotification::SizeChanged, [this] { m_player->sizeChanged(); });
>+        m_notifier->notify(MainThreadNotification::SizeChanged, [this] {
>+            m_player->sizeChanged();
>+        });
>     }
> 
>     if (!m_renderingCanBeAccelerated) {
>-- 
>2.17.0

Actions: View | Formatted Diff | Diff

Attachments on bug 185510: 340085 | 340314