WebKit Bugzilla
Attachment 340073 Details for
Bug 185505
: REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
WIP patch
wip.patch (text/plain), 1.26 KB, created by
Fujii Hironori
on 2018-05-09 23:37:14 PDT
(
hide
)
Description:
WIP patch
Filename:
MIME Type:
Creator:
Fujii Hironori
Created:
2018-05-09 23:37:14 PDT
Size:
1.26 KB
patch
obsolete
>diff --git a/Source/WebKitLegacy/win/WebPreferences.cpp b/Source/WebKitLegacy/win/WebPreferences.cpp >index b78c37aa9f5..a2f05c721e6 100644 >--- a/Source/WebKitLegacy/win/WebPreferences.cpp >+++ b/Source/WebKitLegacy/win/WebPreferences.cpp >@@ -576,6 +576,8 @@ HRESULT WebPreferences::QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppv > *ppvObject = static_cast<IWebPreferencesPrivate5*>(this); > else if (IsEqualGUID(riid, IID_IWebPreferencesPrivate6)) > *ppvObject = static_cast<IWebPreferencesPrivate6*>(this); >+ else if (IsEqualGUID(riid, IID_IWebPreferencesPrivate7)) >+ *ppvObject = static_cast<IWebPreferencesPrivate7*>(this); > else if (IsEqualGUID(riid, CLSID_WebPreferences)) > *ppvObject = this; > else >diff --git a/Source/WebKitLegacy/win/WebPreferences.h b/Source/WebKitLegacy/win/WebPreferences.h >index fc3782a7300..9d93ff28146 100644 >--- a/Source/WebKitLegacy/win/WebPreferences.h >+++ b/Source/WebKitLegacy/win/WebPreferences.h >@@ -30,7 +30,7 @@ > #include <WebCore/BString.h> > #include <wtf/RetainPtr.h> > >-class WebPreferences : public IWebPreferences, public IWebPreferencesPrivate6 { >+class WebPreferences : public IWebPreferences, public IWebPreferencesPrivate7 { > public: > static WebPreferences* createInstance(); > protected:
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185505
:
340073
|
340076