Attachment 340053 Details for Bug 185499 – Patch

[patch] Patch

bug-185499-20180509171004.patch (text/plain), 1.40 KB, created by Eric Carlson on 2018-05-09 17:10:05 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Carlson

Created: 2018-05-09 17:10:05 PDT

Size: 1.40 KB

patch

obsolete

>Subversion Revision: 231494
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a326d412092674f54172d97dec0dd66823d92c6c..c7b7622145b89a6470e140aab6fd9d4ac90a7d36 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-09  Eric Carlson  <eric.carlson@apple.com>
>+
>+        Log missing cues correctly
>+        https://bugs.webkit.org/show_bug.cgi?id=185499
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests, tested manually.
>+
>+        * html/track/InbandGenericTextTrack.cpp:
>+        (WebCore::InbandGenericTextTrack::removeGenericCue): Log the cue we searched for, not
>+        the NULL cue.
>+
> 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
> 
>         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
>diff --git a/Source/WebCore/html/track/InbandGenericTextTrack.cpp b/Source/WebCore/html/track/InbandGenericTextTrack.cpp
>index 58c2bafce3fbff969fa1579a496b5a099ec3499e..7e3e39d677344b8bf1c04935a5955c4606a9868a 100644
>--- a/Source/WebCore/html/track/InbandGenericTextTrack.cpp
>+++ b/Source/WebCore/html/track/InbandGenericTextTrack.cpp
>@@ -156,7 +156,7 @@ void InbandGenericTextTrack::removeGenericCue(GenericCueData& cueData)
>         DEBUG_LOG(LOGIDENTIFIER, *cue);
>         removeCue(*cue);
>     } else
>-        DEBUG_LOG(LOGIDENTIFIER, "UNABLE to find cue: ", *cue);
>+        DEBUG_LOG(LOGIDENTIFIER, "UNABLE to find cue: ", cueData);
> 
> }
>

Flags:

dbates: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185499: 340053 | 340089