Attachment 340038 Details for Bug 185494 – Patch

[patch] Patch

bug-185494-20180510000826.patch (text/plain), 2.25 KB, created by youenn fablet on 2018-05-09 15:08:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-05-09 15:08:27 PDT

Size: 2.25 KB

patch

obsolete

>Subversion Revision: 231552
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index d06399fd2051a0dc6bc8c1ee678eac29db30a531..c5004e0c79e01d9ade444a07c52a7d0b4f8d8aee 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-09  Youenn Fablet  <youenn@apple.com>
>+
>+        LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404.html is flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=185494
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Return the 404 to the manifest request after a delay so that aborting is done first.
>+
>+        * http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt:
>+        * http/tests/appcache/abort-cache-onchecking-manifest-404.html:
>+
> 2018-05-09  Youenn Fablet  <youenn@apple.com>
> 
>         Unflake some additional AppCache tests
>diff --git a/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt b/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt
>index e3a90ee53c2d29ae55d56cad9ef0011f6cced9bf..fe7d83189e153c74d509e4e076b626452352a2fc 100644
>--- a/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt
>+++ b/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt
>@@ -1,4 +1,4 @@
> CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
>-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
>+CONSOLE MESSAGE: line 13: Application Cache download process was aborted.
> This tests that download process was aborted after checking event and before update failed.
> SUCCESS
>diff --git a/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404.html b/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404.html
>index 00854f8d00c76f92afdc7b0bcbb2cc0d8fecad08..a4a53703ff9193ce8a08e594e519b87505a33435 100644
>--- a/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404.html
>+++ b/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404.html
>@@ -1,4 +1,4 @@
>-<html manifest="resources/abort-cache-onchecking-manifest-404.manifest">
>+<html manifest="resources/not-exist.vob.php">
> <script>
> if (window.testRunner) {
>     testRunner.dumpAsText()

Actions: View | Formatted Diff | Diff

Attachments on bug 185494: 340038