Attachment 340029 Details for Bug 185491 – Patch

[patch] Patch

bug-185491-20180509183657.patch (text/plain), 2.23 KB, created by Leo Balter on 2018-05-09 14:36:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Leo Balter

Created: 2018-05-09 14:36:58 PDT

Size: 2.23 KB

patch

obsolete

>Subversion Revision: 231588
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 3c2c06aaf8f216a3821c00c2d506defb73497e63..367d2772a1ec72c0ee49b284caf7e9db951af899 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
>+
>+        Test262-Runner: Improve the verbose output
>+        https://bugs.webkit.org/show_bug.cgi?id=185491
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/test262/Import.pm:
>+        (transferFiles):
>+        * Scripts/test262/Runner.pm:
>+        (processResult):
>+
> 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
> 
>         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
>diff --git a/Tools/Scripts/test262/Import.pm b/Tools/Scripts/test262/Import.pm
>index 46bd467916728234095cd4d01bbcc57afa4af7f9..67a69ffba40c748a30a55de97974ad56393d3cf3 100755
>--- a/Tools/Scripts/test262/Import.pm
>+++ b/Tools/Scripts/test262/Import.pm
>@@ -159,8 +159,8 @@ sub transferFiles {
>     printAndRun("rm -rf $test262Dir\/test") if -e "$test262Dir/test";
> 
>     # Copy from source
>-    printAndRun("cp -r $sourceDir\/harness $test262Dir");
>-    printAndRun("cp -r $sourceDir\/test $test262Dir");
>+    printAndRun("mv $sourceDir\/harness $test262Dir");
>+    printAndRun("mv $sourceDir\/test $test262Dir");
> }
> 
> sub getRevision {
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index d79a3e0c132677c7f346ff428548a341431ac610..dd42f146b2501e47bfa042d438a50afbff70ed8b 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -645,12 +645,14 @@ sub processResult {
>         # or the failure is new.
>         my $printfailure = !$expect || $isnewfailure;
> 
>-        print "! NEW " if $isnewfailure;
>-        print "FAIL $file ($scenario)\n" if $printfailure;
>         if ($verbose) {
>-            print $result;
>+            # Group the data to avoid racing conditions.
>+            print "! NEW FAIL $file ($scenario)\n$result";
>             print "\nFeatures: " . join(', ', @{ $data->{features} }) if $data->{features};
>             print "\n\n";
>+        } else {
>+            print "! NEW " if $isnewfailure;
>+            print "FAIL $file ($scenario)\n" if $printfailure;
>         }
> 
>         $resultdata{result} = 'FAIL';

Actions: View | Formatted Diff | Diff

Attachments on bug 185491: 340029 | 340030