Attachment 340020 Details for Bug 184581 – [GStreamer] Never call updateTracks if running on legacy pipeline

[patch] [GStreamer] Never call updateTracks if running on legacy pipeline

GStreamer-Never-call-updateTracks-if-running-on-le.patch (text/plain), 5.58 KB, created by Thibault Saunier on 2018-05-09 13:52:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thibault Saunier

Created: 2018-05-09 13:52:54 PDT

Size: 5.58 KB

patch

obsolete

>From 01cd73a460b0cd9d8a4edf42f698502d0655eb33 Mon Sep 17 00:00:00 2001
>From: Thibault Saunier <tsaunier@igalia.com>
>Date: Wed, 9 May 2018 16:20:47 -0300
>Subject: [PATCH xserver] [GStreamer] Never call updateTracks if running on
> legacy pipeline
>
>https://bugs.webkit.org/show_bug.cgi?id=184581
>---
> LayoutTests/ChangeLog                          | 11 +++++++++++
> LayoutTests/platform/gtk/TestExpectations      |  9 ++-------
> Source/WebCore/ChangeLog                       | 16 ++++++++++++++++
> .../gstreamer/MediaPlayerPrivateGStreamer.cpp  | 18 ++++++++++--------
> 4 files changed, 39 insertions(+), 15 deletions(-)
>
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index ec35bc67865..57812f3db2a 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
>+
>+        [GStreamer] Never call updateTracks if running on legacy pipeline
>+        https://bugs.webkit.org/show_bug.cgi?id=184581
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=185252
>+
>+        * platform/gtk/TestExpectations:
>+
> 2018-05-09  Youenn Fablet  <youenn@apple.com>
> 
>         Unflake some additional AppCache tests
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index 7aa206948ce..a068fb90bd5 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -1005,6 +1005,8 @@ webkit.org/b/167579 fast/forms/validation-message-minimum-font-size.html [ Skip
> # Tests failing with GStreamer 1.6.3
> webkit.org/b/154390 http/tests/media/video-throttled-load-metadata.html [ Pass Failure ]
> webkit.org/b/154390 http/tests/media/video-redirect.html [ Timeout Pass ]
>+webkit.org/b/154390 [ Release ] http/tests/media/hls/video-controller-getStartDate.html [ Timeout Failure ]
>+webkit.org/b/154390 [ Release ] http/tests/media/hls/hls-audio-tracks-locale-selection.html [ Timeout Failure ]
> webkit.org/b/154390 [ Release ] http/tests/media/hls/hls-video-resize.html [ Timeout Failure ]
> webkit.org/b/154390 http/tests/security/local-video-source-from-remote.html [ Timeout Pass ]
> 
>@@ -1246,11 +1248,6 @@ webkit.org/b/129050 fast/sub-pixel/compositing-layers-on-subpixel-position.html
> 
> webkit.org/b/152043 [ Debug ] http/tests/media/hls [ Timeout Crash ]
> 
>-# Tests crashing since addition of playbin3 usage
>-webkit.org/b/184581 http/tests/media/hls/hls-audio-tracks-locale-selection.html [ Timeout Failure Crash ]
>-webkit.org/b/184581 http/tests/media/hls/hls-progress.html [ Crash ]
>-webkit.org/b/184581 http/tests/media/hls/video-controller-getStartDate.html [ Timeout Failure Crash ]
>-
> webkit.org/b/152642 http/tests/misc/detached-frame-console.html [ Crash Pass Timeout Failure ]
> 
> webkit.org/b/153692 imported/blink/fast/css/first-letter-float-block.html [ Crash Pass ]
>@@ -3358,8 +3355,6 @@ webkit.org/b/184778 inspector/canvas/setShaderProgramHighlighted.html [ Failure
> webkit.org/b/184779 transitions/clip-path-path-transitions.html [ Failure ]
> webkit.org/b/184779 transitions/clip-path-transitions.html [ Failure ]
> 
>-webkit.org/b/185252 http/tests/media/hls/hls-audio-tracks.html [ Failure ]
>-
> webkit.org/b/185254 http/tests/cache/disk-cache/redirect-chain-limits.html [ Failure ]
> webkit.org/b/185254 http/tests/xmlhttprequest/onloadend-event-after-error.html [ Failure ]
> webkit.org/b/185254 http/tests/xmlhttprequest/response-access-on-error.html [ Failure ]
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 4136fb89b6d..73b7fc8c80a 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
>+
>+        [GStreamer] Never call updateTracks if running on legacy pipeline
>+        https://bugs.webkit.org/show_bug.cgi?id=184581
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This makes sure failling code path is never reached in the conditions where it should not have been reached.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Re enables all tests that were disabled after fixing.
>+
>+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
>+        (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
>+
> 2018-05-09  Tim Horton  <timothy_horton@apple.com>
> 
>         Fix the build by ignoring some deprecation warnings
>diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>index 223d43ee811..9b62c82961a 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>@@ -1285,14 +1285,16 @@ void MediaPlayerPrivateGStreamer::handleMessage(GstMessage* message)
>     }
> #if GST_CHECK_VERSION(1, 10, 0)
>     case GST_MESSAGE_STREAM_COLLECTION: {
>-        GRefPtr<GstStreamCollection> collection;
>-        gst_message_parse_stream_collection(message, &collection.outPtr());
>-
>-        if (collection) {
>-            m_streamCollection.swap(collection);
>-            m_notifier->notify(MainThreadNotification::StreamCollectionChanged, [this] {
>-                this->updateTracks();
>-            });
>+        if (!m_isLegacyPlaybin) {
>+            GRefPtr<GstStreamCollection> collection;
>+            gst_message_parse_stream_collection(message, &collection.outPtr());
>+
>+            if (collection) {
>+                m_streamCollection.swap(collection);
>+                m_notifier->notify(MainThreadNotification::StreamCollectionChanged, [this] {
>+                    this->updateTracks();
>+                });
>+            }
>         }
>         break;
>     }
>-- 
>2.17.0

Actions: View | Formatted Diff | Diff

Attachments on bug 184581: 340020 | 340023