Attachment 340015 Details for Bug 185486 – Patch

[patch] Patch

bug-185486-20180509133158.patch (text/plain), 1.78 KB, created by Sihui Liu on 2018-05-09 13:31:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-05-09 13:31:58 PDT

Size: 1.78 KB

patch

obsolete

>Subversion Revision: 231523
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 80ff344c08717025eeca74fe7d03ce7377c7dace..fda0ea7b3ea9e201408cc44009dc502c379c5fca 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-09  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Update WebKit.WebsiteDataStoreCustomPaths after r231536
>+        https://bugs.webkit.org/show_bug.cgi?id=185486
>+        <rdar://problem/37214391>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
>+        (TEST):
>+
> 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
> 
>         Test262-Runner: Add base Perl UnicodeData
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm
>index 5a06808b8599ab826e540ae96328e72ee782f893..662d5f2a848a1a6caf088d23aad386a728874b36 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm
>@@ -143,6 +143,12 @@ TEST(WebKit, WebsiteDataStoreCustomPaths)
>     EXPECT_TRUE([[NSFileManager defaultManager] fileExistsAtPath:localStoragePath.path]);
> 
> #if PLATFORM(IOS) || (__MAC_OS_X_VERSION_MIN_REQUIRED < 101300)
>+    int retryCount = 10;
>+    while (retryCount--) {
>+        if ([[NSFileManager defaultManager] fileExistsAtPath:cookieStorageFile.path])
>+            break;
>+        TestWebKitAPI::Util::spinRunLoop(1);
>+    }
>     EXPECT_TRUE([[NSFileManager defaultManager] fileExistsAtPath:cookieStorageFile.path]);
> 
>     // Note: The format of the cookie file on disk is proprietary and opaque, so this is fragile to future changes.

Actions: View | Formatted Diff | Diff

Attachments on bug 185486: 340015 | 340028