Attachment 339971 Details for Bug 185477 – Patch

[patch] Patch

bug-185477-20180509094601.patch (text/plain), 3.65 KB, created by Andy Estes on 2018-05-09 09:46:02 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andy Estes

Created: 2018-05-09 09:46:02 PDT

Size: 3.65 KB

patch

obsolete

>Subversion Revision: 231509
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 5b14e10b391baaee02a3e2bab2f76ca8d9a2bb10..0c30b65854ca12c27e83422d4f30c84392cc648a 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-05-09  Andy Estes  <aestes@apple.com>
>+
>+        [iOS] Tell PDFHostViewController when animated resizes begin and end
>+        https://bugs.webkit.org/show_bug.cgi?id=185477
>+        <rdar://problem/39875372>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/Cocoa/WKWebView.mm:
>+        (-[WKWebView _beginAnimatedResizeWithUpdates:]):
>+        (-[WKWebView _endAnimatedResize]):
>+        * UIProcess/Cocoa/WKWebViewContentProvider.h:
>+        * UIProcess/ios/WKPDFView.mm:
>+        (-[WKPDFView web_beginAnimatedResize]):
>+        (-[WKPDFView web_endAnimatedResize]):
>+
> 2018-05-08  Dean Jackson  <dino@apple.com>
> 
>         System Preview links should trigger a download
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>index 235a718444ce73fe90af4eca6b6a2d2439ad35e1..0415447df9b9110ba7471bbd22bbb926699d7e74 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>@@ -5147,6 +5147,8 @@ - (void)_beginAnimatedResizeWithUpdates:(void (^)(void))updateBlock
> 
>     if (![self usesStandardContentView] || !_hasCommittedLoadForMainFrame || CGRectIsEmpty(oldBounds) || oldUnobscuredContentRect.isEmpty()) {
>         updateBlock();
>+        if ([_customContentView respondsToSelector:@selector(web_beginAnimatedResize)])
>+            [_customContentView web_beginAnimatedResize];
>         return;
>     }
> 
>@@ -5262,6 +5264,9 @@ - (void)_endAnimatedResize
> {
>     LOG_WITH_STREAM(VisibleRects, stream << "-[WKWebView " << _page->pageID() << " _endAnimatedResize:] " << " _dynamicViewportUpdateMode " << (int)_dynamicViewportUpdateMode);
> 
>+    if ([_customContentView respondsToSelector:@selector(web_endAnimatedResize)])
>+        [_customContentView web_endAnimatedResize];
>+
>     if (_dynamicViewportUpdateMode == DynamicViewportUpdateMode::NotResizing)
>         return;
> 
>diff --git a/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProvider.h b/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProvider.h
>index b7fc59ecdfe542f20ca13ebc80c4b3498dea7999..abf52f04f605ec40c3edeeff3816cc8aa9358202 100644
>--- a/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProvider.h
>+++ b/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProvider.h
>@@ -59,6 +59,8 @@ struct UIEdgeInsets;
> - (void)web_scrollViewWillBeginZooming:(UIScrollView *)scrollView withView:(UIView *)view;
> - (void)web_scrollViewDidEndZooming:(UIScrollView *)scrollView withView:(UIView *)view atScale:(CGFloat)scale;
> - (void)web_scrollViewDidZoom:(UIScrollView *)scrollView;
>+- (void)web_beginAnimatedResize;
>+- (void)web_endAnimatedResize;
> @property (nonatomic, readonly) NSData *web_dataRepresentation;
> @property (nonatomic, readonly) NSString *web_suggestedFilename;
> @property (nonatomic, readonly) BOOL web_isBackground;
>diff --git a/Source/WebKit/UIProcess/ios/WKPDFView.mm b/Source/WebKit/UIProcess/ios/WKPDFView.mm
>index 5cbe8ceaf664f287c636e9ecb14bd4b28653e27a..180a714c98f37bb60528ab6faf7d69e6f091d475 100644
>--- a/Source/WebKit/UIProcess/ios/WKPDFView.mm
>+++ b/Source/WebKit/UIProcess/ios/WKPDFView.mm
>@@ -338,6 +338,16 @@ - (void)web_scrollViewDidZoom:(UIScrollView *)scrollView
>     [_hostViewController updatePDFViewLayout];
> }
> 
>+- (void)web_beginAnimatedResize
>+{
>+    [_hostViewController beginPDFViewRotation];
>+}
>+
>+- (void)web_endAnimatedResize
>+{
>+    [_hostViewController endPDFViewRotation];
>+}
>+
> - (NSData *)web_dataRepresentation
> {
>     return _data.get();

Actions: View | Formatted Diff | Diff

Attachments on bug 185477: 339971