Attachment 339963 Details for Bug 185436 – patch

[patch] patch

0001-Fix-typo-Convertion-Conversion-in-error-message-stri.patch (text/plain), 3.18 KB, created by Rick Waldron on 2018-05-09 08:09:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rick Waldron

Created: 2018-05-09 08:09:47 PDT

Size: 3.18 KB

patch

obsolete

>From c92cd027af20eb0fdf241f6df1c90ebde06da242 Mon Sep 17 00:00:00 2001
>From: Rick Waldron <waldron.rick@gmail.com>
>Date: Tue, 8 May 2018 14:40:31 -0400
>Subject: [PATCH] Fix typo "Convertion" => "Conversion" in error message
> string.
>
>---
> JSTests/ChangeLog                                 |  9 +++++++++
> JSTests/bigIntTests.yaml                          |  2 ++
> JSTests/stress/big-int-no-conversion-to-number.js | 12 ++++++++++++
> Source/JavaScriptCore/ChangeLog                   | 10 ++++++++++
> Source/JavaScriptCore/runtime/JSBigInt.cpp        |  2 +-
> 5 files changed, 34 insertions(+), 1 deletion(-)
> create mode 100644 JSTests/stress/big-int-no-conversion-to-number.js
>
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index 39f48b4710..d465cbce18 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-05-08  Rick Waldron  <waldron.rick@gmail.com>
>+
>+        Conversion misspelled "Convertion" in error message string
>+        https://bugs.webkit.org/show_bug.cgi?id=185436
>+
>+        Reviewed by Saam Barati.
>+
>+        * bigIntTests.yaml:
>+
> 2018-05-08  Valerie R Young  <valerie@bocoup.com>
> 
>         test262/Runner.pm: move input files to JSTests/test262
>diff --git a/JSTests/bigIntTests.yaml b/JSTests/bigIntTests.yaml
>index 7ae22cb1bb..52e3038e94 100644
>--- a/JSTests/bigIntTests.yaml
>+++ b/JSTests/bigIntTests.yaml
>@@ -97,3 +97,5 @@
> - path: stress/big-int-to-string.js
>   cmd: runBigIntEnabled
> 
>+- path: stress/big-int-no-conversion-to-number.js
>+  cmd: runBigIntEnabled
>diff --git a/JSTests/stress/big-int-no-conversion-to-number.js b/JSTests/stress/big-int-no-conversion-to-number.js
>new file mode 100644
>index 0000000000..f380b57522
>--- /dev/null
>+++ b/JSTests/stress/big-int-no-conversion-to-number.js
>@@ -0,0 +1,12 @@
>+//@ runBigIntEnabled
>+
>+let message;
>+try {
>+  1n + 1;
>+} catch (error) {
>+  message = error.message;
>+}
>+
>+if (message !== "Conversion from 'BigInt' to 'number' is not allowed.") {
>+  throw new Error("Error message has changed to something unexpected");
>+}
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 71bc05b6ff..7ceaf8ddfc 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-08  Rick Waldron  <waldron.rick@gmail.com>
>+
>+        Conversion misspelled "Convertion" in error message string
>+        https://bugs.webkit.org/show_bug.cgi?id=185436
>+
>+        Reviewed by Saam Barati.
>+
>+        * runtime/JSBigInt.cpp:
>+        (JSC::JSBigInt::toNumber const):
>+
> 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r231468.
>diff --git a/Source/JavaScriptCore/runtime/JSBigInt.cpp b/Source/JavaScriptCore/runtime/JSBigInt.cpp
>index 3d1e9f183a..ef6afb092b 100644
>--- a/Source/JavaScriptCore/runtime/JSBigInt.cpp
>+++ b/Source/JavaScriptCore/runtime/JSBigInt.cpp
>@@ -701,7 +701,7 @@ double JSBigInt::toNumber(ExecState* state) const
> {
>     VM& vm = state->vm();
>     auto scope = DECLARE_THROW_SCOPE(vm);
>-    throwTypeError(state, scope, ASCIILiteral("Convertion from 'BigInt' to 'number' is not allowed."));
>+    throwTypeError(state, scope, ASCIILiteral("Conversion from 'BigInt' to 'number' is not allowed."));
>     return 0.0;
> }
> 
>-- 
>2.15.1 (Apple Git-101)
>

Flags:

msaboff: review+
commit-queue: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 185436: 339848 | 339963 | 341090