Attachment 339947 Details for Bug 185467 – Patch

[patch] Patch

bug-185467-20180509115429.patch (text/plain), 5.90 KB, created by youenn fablet on 2018-05-09 02:54:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-05-09 02:54:32 PDT

Size: 5.90 KB

patch

obsolete

>Subversion Revision: 231437
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 5847bb8322b8b697d3ceb4a733048003dd7ad296..295fa494232fe728c251446d04c90236690058f0 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-05-09  Youenn Fablet  <youenn@apple.com>
>+
>+        Unflake some additional AppCache tests
>+        https://bugs.webkit.org/show_bug.cgi?id=185467
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove JS console logging for two tests that are testing crash scenarios.
>+        Increase the time it takes to load appcache entries so that aborting
>+        is done prior entry loading completion for two other tests.
>+
>+        * TestExpectations:
>+        * http/tests/appcache/deferred-events-delete-while-raising-expected.txt:
>+        * http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt:
>+        * http/tests/appcache/resources/abort-cache-onprogress.manifest:
>+        * http/tests/appcache/resources/not-exist.vob.php:
>+
> 2018-05-08  Youenn Fablet  <youenn@apple.com>
> 
>         Some appcache crash tests are flaky due to console messages
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index c0973bf09216032d24035b76d03c0ad758997a68..484e6e45a8d61056da16952afdf7f2f2a176a11e 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -1009,21 +1009,14 @@ webkit.org/b/140043 js/dom/Promise.html [ Pass Failure ]
> webkit.org/b/134550 http/tests/cache/iframe-304-crash.html [ Failure Pass ]
> webkit.org/b/141267 http/tests/misc/detached-frame-console.html [ Pass Failure ]
> 
>-# Aborting application cache abort tests are intrinsically flaky.
>-webkit.org/b/87633 http/tests/appcache/abort-cache-onchecking-manifest-404.html [ Pass Failure ]
>-webkit.org/b/87633 http/tests/appcache/abort-cache-ondownloading-resource-404.html [ Pass Failure ]
>-webkit.org/b/87633 http/tests/appcache/deferred-events-delete-while-raising-timer.html [ Pass Failure ]
>-webkit.org/b/87633 http/tests/appcache/deferred-events-delete-while-raising.html [ Pass Failure ]
>-webkit.org/b/87633 http/tests/appcache/deferred-events.html [ Pass Failure ]
>-
>+http/tests/appcache/deferred-events-delete-while-raising-timer.html [ DumpJSConsoleLogInStdErr ]
>+http/tests/appcache/deferred-events-delete-while-raising.html [ DumpJSConsoleLogInStdErr ]
> http/tests/appcache/fail-on-update.html [ DumpJSConsoleLogInStdErr ]
> http/tests/appcache/fail-on-update-2.html [ DumpJSConsoleLogInStdErr ]
> http/tests/appcache/404-resource-with-slow-main-resource.php [ DumpJSConsoleLogInStdErr ]
> 
> webkit.org/b/141370 http/tests/security/appcache-in-private-browsing.html [ Pass Failure ]
> 
>-webkit.org/b/183684 http/tests/appcache/abort-cache-onprogress.html [ Pass Failure ]
>-
> # The current expectations for this test only make sense for WebKit on iOS; other platforms can have very different behaviors.
> webkit.org/b/141488 fast/replaced/pdf-as-object-and-embed.html [ Skip ]
> 
>diff --git a/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-expected.txt b/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-expected.txt
>index 930878cf74c159739e4d70b1cb75a599aa017190..8e41eb6faf5b3b9992dd4724df02e3f61f054128 100644
>--- a/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-expected.txt
>+++ b/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-expected.txt
>@@ -1,7 +1,3 @@
>-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
>-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
>-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
>-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
> Test the destruction of an iframe while deferred events are being raised does not crash the system.
> 
> SUCCESS
>diff --git a/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt b/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt
>index 930878cf74c159739e4d70b1cb75a599aa017190..8e41eb6faf5b3b9992dd4724df02e3f61f054128 100644
>--- a/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt
>+++ b/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt
>@@ -1,7 +1,3 @@
>-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
>-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
>-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
>-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
> Test the destruction of an iframe while deferred events are being raised does not crash the system.
> 
> SUCCESS
>diff --git a/LayoutTests/http/tests/appcache/resources/abort-cache-onprogress.manifest b/LayoutTests/http/tests/appcache/resources/abort-cache-onprogress.manifest
>index 2f5ab5dadf6de83335e4dae4bd1c752fd4ff0ba0..95975ca202dfe7c4cb37a0d8f82cd4c40de6bdf4 100644
>--- a/LayoutTests/http/tests/appcache/resources/abort-cache-onprogress.manifest
>+++ b/LayoutTests/http/tests/appcache/resources/abort-cache-onprogress.manifest
>@@ -2,5 +2,4 @@ CACHE MANIFEST
> abort-cache-onprogress-1.text
> abort-cache-onprogress-2.text
> abort-cache-onprogress-3.text
>-abort-cache-onprogress-4.text
>-
>+slow-resource.php
>diff --git a/LayoutTests/http/tests/appcache/resources/not-exist.vob.php b/LayoutTests/http/tests/appcache/resources/not-exist.vob.php
>index 4d4dc9fbf325128049a353d1c04d90adc6c6e57e..7a6570cf3f6a99ea593fd8732a6f634619e0170d 100644
>--- a/LayoutTests/http/tests/appcache/resources/not-exist.vob.php
>+++ b/LayoutTests/http/tests/appcache/resources/not-exist.vob.php
>@@ -1,5 +1,5 @@
> <?php
>-sleep(1000);
>+sleep(5000);
> header('http/1.1 404 Not Found');
> print("File not found\n");
> ?>

Actions: View | Formatted Diff | Diff

Attachments on bug 185467: 339947