WebKit Bugzilla
Attachment 339930 Details for
Bug 185464
: [MIPS] Use mfhc1 and mthc1 to fix assembler error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185464-20180509072718.patch (text/plain), 1.96 KB, created by
Dominik Inführ
on 2018-05-08 22:27:19 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Dominik Inführ
Created:
2018-05-08 22:27:19 PDT
Size:
1.96 KB
patch
obsolete
>Subversion Revision: 231483 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index e69a3cf25d04636ddf2ec1a6bf5751e174860948..bff0e157aec296e715f410f0cf06bd8e1c7a111d 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,16 @@ >+2018-05-08 Dominik Infuehr <dinfuehr@igalia.com> >+ >+ [MIPS] Use mfhc1 and mthc1 to fix assembler error >+ https://bugs.webkit.org/show_bug.cgi?id=185464 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ The binutils-assembler started to report failures for copying words between >+ GP and FP registers for odd FP register indices. Use mfhc1 and mthc1 instead >+ of mfc1 and mtc1 for conversion. >+ >+ * offlineasm/mips.rb: >+ > 2018-05-07 Daniel Bates <dabates@apple.com> > > Check X-Frame-Options and CSP frame-ancestors in network process >diff --git a/Source/JavaScriptCore/offlineasm/mips.rb b/Source/JavaScriptCore/offlineasm/mips.rb >index 8b71f287f0ac2ccf17091efe99afe1c954d563e2..32eea5ad1a7d60c8020a1014e17f20e1b7673cc2 100644 >--- a/Source/JavaScriptCore/offlineasm/mips.rb >+++ b/Source/JavaScriptCore/offlineasm/mips.rb >@@ -1014,10 +1014,10 @@ class Instruction > $asm.puts "sw #{operands[1].mipsOperand}, #{operands[0].value * 4}($sp)" > when "fii2d" > $asm.puts "mtc1 #{operands[0].mipsOperand}, #{operands[2].mipsSingleLo}" >- $asm.puts "mtc1 #{operands[1].mipsOperand}, #{operands[2].mipsSingleHi}" >+ $asm.puts "mthc1 #{operands[1].mipsOperand}, #{operands[2].mipsSingleLo}" > when "fd2ii" > $asm.puts "mfc1 #{operands[1].mipsOperand}, #{operands[0].mipsSingleLo}" >- $asm.puts "mfc1 #{operands[2].mipsOperand}, #{operands[0].mipsSingleHi}" >+ $asm.puts "mfhc1 #{operands[2].mipsOperand}, #{operands[0].mipsSingleLo}" > when /^bo/ > $asm.puts "bgt #{operands[0].mipsOperand}, #{operands[1].mipsOperand}, #{operands[2].asmLabel}" > when /^bs/
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185464
: 339930