WebKit Bugzilla
Attachment 339926 Details for
Bug 185463
: Disable system preview link fetching
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185463-20180508212143.patch (text/plain), 1.67 KB, created by
Dean Jackson
on 2018-05-08 21:21:46 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Dean Jackson
Created:
2018-05-08 21:21:46 PDT
Size:
1.67 KB
patch
obsolete
>Subversion Revision: 231399 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 2bcc15bf0703c11ab401de5b9f0fea3d8071a292..1cbc245e937fac4e497cd9173fe091e9d328b998 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,16 @@ >+2018-05-08 Dean Jackson <dino@apple.com> >+ >+ Disable system preview link fetching >+ https://bugs.webkit.org/show_bug.cgi?id=185463 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Temporarily disable system preview detection when a link >+ is clicked. >+ >+ * html/HTMLAnchorElement.cpp: >+ (WebCore::HTMLAnchorElement::handleClick): >+ > 2018-05-08 Dean Jackson <dino@apple.com> > > System Preview links should trigger a download >diff --git a/Source/WebCore/html/HTMLAnchorElement.cpp b/Source/WebCore/html/HTMLAnchorElement.cpp >index 89a38c1782c38c3b3b12a2fe10db730640ec95f6..a73f680e259b64bf4123543108cd6dd420f4e40f 100644 >--- a/Source/WebCore/html/HTMLAnchorElement.cpp >+++ b/Source/WebCore/html/HTMLAnchorElement.cpp >@@ -418,10 +418,6 @@ void HTMLAnchorElement::handleClick(Event& event) > #endif > > bool isSystemPreview = false; >-#if USE(SYSTEM_PREVIEW) >- isSystemPreview = isSystemPreviewLink(); >-#endif >- > ShouldSendReferrer shouldSendReferrer = hasRel(Relation::NoReferrer) ? NeverSendReferrer : MaybeSendReferrer; > auto newFrameOpenerPolicy = hasRel(Relation::NoOpener) ? std::make_optional(NewFrameOpenerPolicy::Suppress) : std::nullopt; > frame->loader().urlSelected(completedURL, target(), &event, LockHistory::No, LockBackForwardList::No, shouldSendReferrer, document().shouldOpenExternalURLsPolicyToPropagate(), newFrameOpenerPolicy, downloadAttribute, isSystemPreview);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
jonlee
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185463
: 339926