WebKit Bugzilla
Attachment 339896 Details for
Bug 185455
: Don't clear selection until we are actually interacting with a Node.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185455-20180508164324.patch (text/plain), 1.45 KB, created by
Megan Gardner
on 2018-05-08 16:43:25 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Megan Gardner
Created:
2018-05-08 16:43:25 PDT
Size:
1.45 KB
patch
obsolete
>Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 231523) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,16 @@ >+2018-05-08 Megan Gardner <megan_gardner@apple.com> >+ >+ Don't clear selection until we are actually interacting with a Node. >+ https://bugs.webkit.org/show_bug.cgi?id=185455 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ The presence of TextInteractionAssistant should not be used as a proxy for it we are actually editing content. >+ We need to check to see if we have an active node, and then we should clear the selection. >+ >+ * UIProcess/ios/WKContentViewInteraction.mm: >+ (-[WKContentView setSelectedTextRange:]): >+ > 2018-05-08 Daniel Bates <dabates@apple.com> > > Do not apply X-Frame-Options and CSP frame-ancestors to Quick Look-applicable responses in NetworkProcess >Index: Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >=================================================================== >--- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (revision 231445) >+++ Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (working copy) >@@ -3220,7 +3220,7 @@ - (NSArray *)selectionRectsForRange:(UIT > > - (void)setSelectedTextRange:(UITextRange *)range > { >- if (_textSelectionAssistant && !range) >+ if (hasAssistedNode(_assistedNodeInformation) && !range) > [self clearSelection]; > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185455
: 339896