Attachment 339889 Details for Bug 185445 – Patch

[patch] Patch

bug-185445-20180508153313.patch (text/plain), 2.29 KB, created by Per Arne Vollan on 2018-05-08 15:33:14 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Per Arne Vollan

Created: 2018-05-08 15:33:14 PDT

Size: 2.29 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 231510)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-05-08  Per Arne Vollan  <pvollan@apple.com>
>+
>+        Set colorspace in the PDF plugin.
>+        https://bugs.webkit.org/show_bug.cgi?id=185445
>+        <rdar://problem/40030981>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
>+        * WebProcess/Plugins/PDF/PDFPlugin.mm:
>+        (WebKit::PDFPlugin::PDFPlugin):
>+
> 2018-05-08  Per Arne Vollan  <pvollan@apple.com>
> 
>         The PDF context menu should not be created in the WebContent process.
>Index: Source/WebKit/WebProcess/Plugins/PDF/PDFLayerControllerSPI.h
>===================================================================
>--- Source/WebKit/WebProcess/Plugins/PDF/PDFLayerControllerSPI.h	(revision 231510)
>+++ Source/WebKit/WebProcess/Plugins/PDF/PDFLayerControllerSPI.h	(working copy)
>@@ -166,6 +166,9 @@ typedef NS_ENUM(NSInteger, PDFLayerContr
> - (id)accessibilityElementForAnnotation:(PDFAnnotation *)annotation;
> #endif
> 
>+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
>+- (void)setDeviceColorSpace:(CGColorSpaceRef)colorSpace;
>+#endif
> @end
> 
> #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
>Index: Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
>===================================================================
>--- Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm	(revision 231510)
>+++ Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm	(working copy)
>@@ -74,6 +74,7 @@
> #import <WebCore/PDFDocumentImage.h>
> #import <WebCore/Page.h>
> #import <WebCore/Pasteboard.h>
>+#import <WebCore/PlatformScreen.h>
> #import <WebCore/PluginData.h>
> #import <WebCore/PluginDocument.h>
> #import <WebCore/RenderBoxModelObject.h>
>@@ -632,6 +633,12 @@ inline PDFPlugin::PDFPlugin(WebFrame& fr
> 
>     [m_containerLayer addSublayer:m_contentLayer.get()];
>     [m_containerLayer addSublayer:m_scrollCornerLayer.get()];
>+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
>+    if ([m_pdfLayerController respondsToSelector:@selector(setDeviceColorSpace:)]) {
>+        auto view = webFrame()->coreFrame()->view();
>+        [m_pdfLayerController setDeviceColorSpace:screenColorSpace(view)];
>+    }
>+#endif
> }
> 
> PDFPlugin::~PDFPlugin()

Actions: View | Formatted Diff | Diff

Attachments on bug 185445: 339869 | 339889