WebKit Bugzilla
Attachment 339888 Details for
Bug 185451
: Switch some RELEASE_ASSERTS to plain debug ASSERTS in PlatformScreenMac.mm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185451-20180508152659.patch (text/plain), 4.57 KB, created by
Brent Fulgham
on 2018-05-08 15:26:59 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Brent Fulgham
Created:
2018-05-08 15:26:59 PDT
Size:
4.57 KB
patch
obsolete
>Subversion Revision: 231459 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index d0f5a2181c03bb229e8975208300bc537080ccb0..0e719ff6178af96644a185292869b2497c75e8d1 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,26 @@ >+2018-05-08 Brent Fulgham <bfulgham@apple.com> >+ >+ Switch some RELEASE_ASSERTS to plain debug ASSERTS in PlatformScreenMac.mm >+ https://bugs.webkit.org/show_bug.cgi?id=185451 >+ <rdar://problem/39620348> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Change a set of RELEASE_ASSERTS used to prevent accessing NSScreen related functions in the >+ PlatformScreenMac implementation to less expensive Debug ASSERTS. >+ >+ No change in behavior. >+ >+ * platform/mac/PlatformScreenMac.mm: >+ (WebCore::screenHasInvertedColors): >+ (WebCore::screenDepth): >+ (WebCore::screenDepthPerComponent): >+ (WebCore::screenRectForDisplay): >+ (WebCore::screenRect): >+ (WebCore::screenAvailableRect): >+ (WebCore::screenColorSpace): >+ (WebCore::screenSupportsExtendedColor): >+ > 2018-05-07 Brent Fulgham <bfulgham@apple.com> > > Add experimental feature to prompt for Storage Access API use >diff --git a/Source/WebCore/platform/mac/PlatformScreenMac.mm b/Source/WebCore/platform/mac/PlatformScreenMac.mm >index 815aa65eb0b8538a866e460a793a0c16b8e914a0..629812231dc50d9998a41c160e59d29f9442a8fc 100644 >--- a/Source/WebCore/platform/mac/PlatformScreenMac.mm >+++ b/Source/WebCore/platform/mac/PlatformScreenMac.mm >@@ -181,7 +181,7 @@ bool screenHasInvertedColors() > return screenProperties(primaryScreenDisplayID()).screenHasInvertedColors; > > // This is a system-wide accessibility setting, same on all screens. >- RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); >+ ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); > return CGDisplayUsesInvertedPolarity(); > } > >@@ -193,7 +193,7 @@ int screenDepth(Widget* widget) > return screenDepth; > } > >- RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); >+ ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); > return NSBitsPerPixelFromDepth(screen(widget).depth); > } > >@@ -205,7 +205,7 @@ int screenDepthPerComponent(Widget* widget) > return depthPerComponent; > } > >- RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); >+ ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); > return NSBitsPerSampleFromDepth(screen(widget).depth); > } > >@@ -217,7 +217,7 @@ FloatRect screenRectForDisplay(PlatformDisplayID displayID) > return screenRect; > } > >- RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); >+ ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); > return screen(displayID).frame; > } > >@@ -226,7 +226,7 @@ FloatRect screenRect(Widget* widget) > if (!screenProperties().isEmpty()) > return getScreenProperties(widget).screenRect; > >- RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); >+ ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); > return toUserSpace([screen(widget) frame], window(widget)); > } > >@@ -235,7 +235,7 @@ FloatRect screenAvailableRect(Widget* widget) > if (!screenProperties().isEmpty()) > return getScreenProperties(widget).screenAvailableRect; > >- RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); >+ ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); > return toUserSpace([screen(widget) visibleFrame], window(widget)); > } > >@@ -260,7 +260,7 @@ CGColorSpaceRef screenColorSpace(Widget* widget) > if (!screenProperties().isEmpty()) > return getScreenProperties(widget).colorSpace.get(); > >- RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); >+ ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); > return screen(widget).colorSpace.CGColorSpace; > } > >@@ -269,7 +269,7 @@ bool screenSupportsExtendedColor(Widget* widget) > if (!screenProperties().isEmpty()) > return getScreenProperties(widget).screenSupportsExtendedColor; > >- RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); >+ ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)); > return [screen(widget) canRepresentDisplayGamut:NSDisplayGamutP3]; > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
zalan
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185451
: 339888