Attachment 339887 Details for Bug 183089 – FIX

[patch] FIX

183089.diff (text/plain), 1.50 KB, created by Basuke Suzuki on 2018-05-08 15:08:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2018-05-08 15:08:16 PDT

Size: 1.50 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index fd142b5eb23..9abfec18ed8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-08  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [Curl] Bug fix on suspend/resume behavior.
>+        https://bugs.webkit.org/show_bug.cgi?id=183089
>+
>+        The flag was not set correctly. Also wrong method was called.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/network/curl/CurlRequest.cpp:
>+        (WebCore::CurlRequest::setupTransfer):
>+        (WebCore::CurlRequest::setRequestPaused):
>+
> 2018-05-07  Chris Dumez  <cdumez@apple.com>
> 
>         ASSERT(!childItemWithTarget(child->target())) is hit in HistoryItem::addChildItem()
>diff --git a/Source/WebCore/platform/network/curl/CurlRequest.cpp b/Source/WebCore/platform/network/curl/CurlRequest.cpp
>index f2d0c9b670e..192ea82b359 100644
>--- a/Source/WebCore/platform/network/curl/CurlRequest.cpp
>+++ b/Source/WebCore/platform/network/curl/CurlRequest.cpp
>@@ -223,7 +223,7 @@ CURL* CurlRequest::setupTransfer()
>     m_curlHandle->setCACertPath(sslHandle.getCACertPath());
> 
>     if (m_shouldSuspend)
>-        suspend();
>+        setRequestPaused(true);
> 
> #ifndef NDEBUG
>     m_curlHandle->enableVerboseIfUsed();
>@@ -584,7 +584,7 @@ void CurlRequest::setRequestPaused(bool paused)
> {
>     auto wasPaused = isPaused();
> 
>-    m_isPausedOfRequest = paused;
>+    m_shouldSuspend = m_isPausedOfRequest = paused;
> 
>     if (isPaused() == wasPaused)
>         return;

Actions: View | Formatted Diff | Diff

Attachments on bug 183089: 334541 | 339887 | 340529 | 340530 | 340621 | 340625 | 340674 | 340683 | 340691 | 340713