Attachment 339850 Details for Bug 184933 – Patch

[patch] Patch

bug-184933-20180508155106.patch (text/plain), 7.13 KB, created by Leo Balter on 2018-05-08 11:51:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Leo Balter

Created: 2018-05-08 11:51:08 PDT

Size: 7.13 KB

patch

obsolete

>Subversion Revision: 231494
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index f6ca41869b08a7b4a5f30ecdbede5e46e828b746..6ef9d4c19c6f68bf8ad32f9290f0f705aeb29918 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
>+
>+        Set build.webkit.org to use the new Test262-runner
>+        https://bugs.webkit.org/show_bug.cgi?id=184933
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/build.webkit.org-config/steps.py:
>+        (RunTest262Tests):
>+        (RunTest262Tests.countFailures):
>+        * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
>+
> 2018-05-08  Valerie R Young  <valerie@bocoup.com>
> 
>         test262/Runner.pm: move input files to JSTests/test262
>diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py b/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>index cef7454e9ff740f14d06d33d1a2161907b649500..bfe7ed17813470124f2359d2f279c365682ac6f1 100644
>--- a/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>@@ -359,7 +359,7 @@ class RunTest262Tests(TestWithFailureCount):
>     description = ["test262-tests running"]
>     descriptionDone = ["test262-tests"]
>     failedTestsFormatString = "%d Test262 test%s failed"
>-    command = ["ruby", "./Tools/Scripts/run-jsc-stress-tests", WithProperties("--%(configuration)s"), "JSTests/test262.yaml"]
>+    command = ["perl", "./Tools/Scripts/test262-runner"]
> 
>     def start(self):
>         appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))
>@@ -367,7 +367,7 @@ class RunTest262Tests(TestWithFailureCount):
> 
>     def countFailures(self, cmd):
>         logText = cmd.logs['stdio'].getText()
>-        matches = re.findall(r'^FAIL:', logText, flags=re.MULTILINE)
>+        matches = re.findall(r'^\! NEW FAIL', logText, flags=re.MULTILINE)
>         if matches:
>             return len(matches)
>         return 0
>diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py b/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
>index 1cb77da071ab4e1a66809fa029088f7a58148e09..65bd1128039403fbc56a10cfbfff17965f5bb4ca 100755
>--- a/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
>+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
>@@ -135,30 +135,86 @@ class RunTest262TestsTest(unittest.TestCase):
>         self.assertEqual(actual_text, expected_text)
> 
>     def test_no_regressions_output(self):
>-        self.assertResults(SUCCESS, ["test262-test"], 0, """Using the following jsc path: /WebKitBuild/Release/jsc
>-
>-Running test262.yaml/test262/test/annexB/built-ins/Date/prototype/getYear/length.js.default
>-Running test262.yaml/test262/test/annexB/built-ins/Date/prototype/getYear/length.js.default-strict
>+        self.assertResults(SUCCESS, ["test262-test"], 0, """
>+-------------------------Settings------------------------
>+Test262 Dir: JSTests/test262
>+JSC: WebKitBuild/Release/jsc
>+DYLD_FRAMEWORK_PATH: WebKitBuild/Release
>+Child Processes: 32
>+Config file: Tools/Scripts/test262/config.yaml
>+Expectations file: Tools/Scripts/test262/expectations.yaml
>+--------------------------------------------------------
>+
>+NEW PASS: test/annexB/built-ins/Date/prototype/getYear/length.js (default)
>+NEW PASS test/language/expressions/class/fields-after-same-line-static-method-computed-symbol-names.js (default)
>+
>+Run with --save to save a new expectations file
>+Saved all the results in Tools/Scripts/test262/results.yaml
>+Summarizing results...
>+See summarized results in Tools/Scripts/test262/results-summary.txt
>+
>+56071 tests ran
>+0 expected tests failed
>+0 tests newly fail
>+2546 tests newly pass
>+1241 test files skipped
>+Done in 247 seconds!
> """)
> 
>     def test_failure_output(self):
>-        self.assertResults(FAILURE, ["1 Test262 test failed"], 0, """Using the following jsc path: /WebKitBuild/Release/jsc
>-
>-Running test262.yaml/test262/test/annexB/built-ins/Date/prototype/getYear/length.js.default
>-Running test262.yaml/test262/test/annexB/built-ins/Date/prototype/getYear/length.js.default-strict
>-test262.yaml/test262/test/annexB/built-ins/Date/prototype/getYear/length.js.default-strict: ERROR: Unexpected exit code: 0
>-FAIL: test262.yaml/test262/test/annexB/built-ins/Date/prototype/getYear/length.js.default-strict
>+        self.assertResults(FAILURE, ["1 Test262 test failed"], 0, """
>+-------------------------Settings------------------------
>+Test262 Dir: JSTests/test262
>+JSC: WebKitBuild/Release/jsc
>+DYLD_FRAMEWORK_PATH: WebKitBuild/Release
>+Child Processes: 32
>+Config file: Tools/Scripts/test262/config.yaml
>+Expectations file: Tools/Scripts/test262/expectations.yaml
>+--------------------------------------------------------
>+
>+! NEW FAIL: test/annexB/built-ins/Date/prototype/getYear/length.js (default)
>+NEW PASS test/language/expressions/class/fields-after-same-line-static-method-computed-symbol-names.js (default)
>+
>+Run with --save to save a new expectations file
>+Saved all the results in Tools/Scripts/test262/results.yaml
>+Summarizing results...
>+See summarized results in Tools/Scripts/test262/results-summary.txt
>+
>+56071 tests ran
>+0 expected tests failed
>+0 tests newly fail
>+2546 tests newly pass
>+1241 test files skipped
>+Done in 247 seconds!
> """)
> 
>     def test_failures_output(self):
>-        self.assertResults(FAILURE, ["2 Test262 tests failed"], 0, """Using the following jsc path: /WebKitBuild/Release/jsc
>-
>-Running test262.yaml/test262/test/annexB/built-ins/Date/prototype/getYear/length.js.default
>-test262.yaml/test262/test/annexB/built-ins/Date/prototype/getYear/length.js.default: ERROR: Unexpected exit code: 0
>-FAIL: test262.yaml/test262/test/annexB/built-ins/Date/prototype/getYear/length.js.default
>-Running test262.yaml/test262/test/annexB/built-ins/Date/prototype/getYear/length.js.default-strict
>-test262.yaml/test262/test/annexB/built-ins/Date/prototype/getYear/length.js.default-strict: ERROR: Unexpected exit code: 0
>-FAIL: test262.yaml/test262/test/annexB/built-ins/Date/prototype/getYear/length.js.default-strict
>+        self.assertResults(FAILURE, ["2 Test262 tests failed"], 0, """
>+-------------------------Settings------------------------
>+Test262 Dir: JSTests/test262
>+JSC: WebKitBuild/Release/jsc
>+DYLD_FRAMEWORK_PATH: WebKitBuild/Release
>+Child Processes: 32
>+Config file: Tools/Scripts/test262/config.yaml
>+Expectations file: Tools/Scripts/test262/expectations.yaml
>+--------------------------------------------------------
>+
>+NEW PASS test/language/statements/class/fields-after-same-line-static-async-gen-computed-names.js (default)
>+! NEW FAIL: test/annexB/built-ins/Date/prototype/getYear/length.js (default)
>+! NEW FAIL: test/annexB/built-ins/Date/prototype/getYear/length.js (strict mode)
>+NEW PASS test/language/expressions/class/fields-after-same-line-static-method-computed-symbol-names.js (default)
>+
>+Run with --save to save a new expectations file
>+Saved all the results in Tools/Scripts/test262/results.yaml
>+Summarizing results...
>+See summarized results in Tools/Scripts/test262/results-summary.txt
>+
>+56071 tests ran
>+0 expected tests failed
>+0 tests newly fail
>+2546 tests newly pass
>+1241 test files skipped
>+Done in 247 seconds!
> """)
> 
>

Actions: View | Formatted Diff | Diff

Attachments on bug 184933: 339850 | 339902