Attachment 339848 Details for Bug 185436 – patch

[patch] patch

0001-Fix-typo-Convertion-Conversion-in-error-message-stri.patch (text/plain), 1.60 KB, created by Rick Waldron on 2018-05-08 11:41:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rick Waldron

Created: 2018-05-08 11:41:50 PDT

Size: 1.60 KB

patch

obsolete

>From 6419275b1ea3bf383d6f30ae00276e6cadac0697 Mon Sep 17 00:00:00 2001
>From: Rick Waldron <waldron.rick@gmail.com>
>Date: Tue, 8 May 2018 14:40:31 -0400
>Subject: [PATCH] Fix typo "Convertion" => "Conversion" in error message
> string.
>
>---
> Source/JavaScriptCore/ChangeLog            | 10 ++++++++++
> Source/JavaScriptCore/runtime/JSBigInt.cpp |  2 +-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 71bc05b6ff..c949031a29 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-08  Rick Waldron  <waldron.rick@gmail.com>
>+
>+        Conversion misspelled "Convertion" in error message string
>+        https://bugs.webkit.org/show_bug.cgi?id=185436
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * runtime/JSBigInt.cpp:
>+        (JSC::JSBigInt::toNumber const):
>+
> 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r231468.
>diff --git a/Source/JavaScriptCore/runtime/JSBigInt.cpp b/Source/JavaScriptCore/runtime/JSBigInt.cpp
>index 3d1e9f183a..ef6afb092b 100644
>--- a/Source/JavaScriptCore/runtime/JSBigInt.cpp
>+++ b/Source/JavaScriptCore/runtime/JSBigInt.cpp
>@@ -701,7 +701,7 @@ double JSBigInt::toNumber(ExecState* state) const
> {
>     VM& vm = state->vm();
>     auto scope = DECLARE_THROW_SCOPE(vm);
>-    throwTypeError(state, scope, ASCIILiteral("Convertion from 'BigInt' to 'number' is not allowed."));
>+    throwTypeError(state, scope, ASCIILiteral("Conversion from 'BigInt' to 'number' is not allowed."));
>     return 0.0;
> }
> 
>-- 
>2.15.1 (Apple Git-101)
>

Flags:

saam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185436: 339848 | 339963 | 341090