Attachment 339842 Details for Bug 185198 – WIP

[patch] WIP

bug-185198-20180508202243.patch (text/plain), 11.66 KB, created by Zan Dobersek on 2018-05-08 11:22:44 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2018-05-08 11:22:44 PDT

Size: 11.66 KB

patch

obsolete

>Subversion Revision: 231482
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index bc6041bf7ed5b8f9814df3647ef6f4054b41e3c8..3c39ee79c4495a8dd65c7b48bfd8b10582bb8383 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-08  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [GTK] REGRESSION(r231170) Build broken with Clang 5.0
>+        https://bugs.webkit.org/show_bug.cgi?id=185198
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/Compiler.h:
>+        * wtf/Forward.h:
>+        * wtf/Hasher.h:
>+        * wtf/StdLibExtras.h:
>+
> 2018-05-07  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [JSCONLY] Enable ARMv7 DFG
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 9978f968a09a6e95f12bfc811c4711f7d5951d57..5309e54275699d58a645d0d83a0a272e6d12aaa2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-05-08  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [GTK] REGRESSION(r231170) Build broken with Clang 5.0
>+        https://bugs.webkit.org/show_bug.cgi?id=185198
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * css/makeSelectorPseudoClassAndCompatibilityElementMap.py:
>+        * css/makeSelectorPseudoElementsMap.py:
>+        * css/makeprop.pl:
>+        * css/makevalues.pl:
>+        * platform/ColorData.gperf:
>+        * platform/Theme.h:
>+        * platform/network/create-http-header-name-table:
>+
> 2018-05-07  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Add FormattingContext::layoutOutOfFlowDescendants implementation
>diff --git a/Source/WTF/wtf/Compiler.h b/Source/WTF/wtf/Compiler.h
>index 1391eadf8ed1cfa280dfcdf5a3612097d73abe33..31c2936911ffb96fbb003d4a27b6996ccf804682 100644
>--- a/Source/WTF/wtf/Compiler.h
>+++ b/Source/WTF/wtf/Compiler.h
>@@ -74,6 +74,8 @@
> #define WTF_CPP_STD_VER 11
> #elif __cplusplus <= 201402L
> #define WTF_CPP_STD_VER 14
>+#elif __cplusplus <= 201703L
>+#define WTF_CPP_STD_VER 17
> #endif
> #endif
> 
>diff --git a/Source/WTF/wtf/Forward.h b/Source/WTF/wtf/Forward.h
>index 81938fce41d6138f3de362a5f89c5dbfbd2d701f..dde7ec030b76f020f82dcbb5e884a4634fabd9a9 100644
>--- a/Source/WTF/wtf/Forward.h
>+++ b/Source/WTF/wtf/Forward.h
>@@ -22,10 +22,6 @@
> 
> #include <stddef.h>
> 
>-namespace std {
>-template<typename T> class optional;
>-}
>-
> namespace WTF {
> 
> class AtomicString;
>diff --git a/Source/WTF/wtf/Hasher.h b/Source/WTF/wtf/Hasher.h
>index 1439391cd52020a8ce98b28311e342dd8e3098cc..e3496e6d33bec652bfd0822247c0e3de9896c54e 100644
>--- a/Source/WTF/wtf/Hasher.h
>+++ b/Source/WTF/wtf/Hasher.h
>@@ -21,6 +21,7 @@
> #pragma once
> 
> #include <wtf/Forward.h>
>+#include <wtf/Optional.h>
> #include <wtf/StdLibExtras.h>
> #include <wtf/text/StringHasher.h>
> 
>diff --git a/Source/WTF/wtf/StdLibExtras.h b/Source/WTF/wtf/StdLibExtras.h
>index 49f2e2988d926bc56595ebc9a0ce927184087abe..b78aaeb6bd77b77ad5b7f31f265ede59f5b45e56 100644
>--- a/Source/WTF/wtf/StdLibExtras.h
>+++ b/Source/WTF/wtf/StdLibExtras.h
>@@ -543,7 +543,7 @@ template<class B0, class B1, class B2, class... Bn> struct wtf_conjunction_impl<
> template<class... _Args> struct conjunction : wtf_conjunction_impl<_Args...> { };
> #endif
> 
>-#if __cplusplus < 201703L
>+#if __cplusplus < 201703L || (defined(__GLIBCXX__) && !defined(_GLIBCXX_RELEASE))
> 
> // These are inline variable for C++17 and later.
> #define __IN_PLACE_INLINE_VARIABLE static const
>diff --git a/Source/WebCore/Modules/webvr/VRDisplay.cpp b/Source/WebCore/Modules/webvr/VRDisplay.cpp
>index 127cc5c838214a282d30797a76b518cd929192cf..1700bedda85707c370b6d100cecec8e8fc01daff 100644
>--- a/Source/WebCore/Modules/webvr/VRDisplay.cpp
>+++ b/Source/WebCore/Modules/webvr/VRDisplay.cpp
>@@ -53,7 +53,7 @@ VRDisplay::VRDisplay(ScriptExecutionContext& context, WeakPtr<VRPlatformDisplay>
>     : ActiveDOMObject(&context)
>     , m_display(WTFMove(platformDisplay))
> {
>-    auto displayInfo = m_display->getDisplayInfo();
>+    auto& displayInfo = m_display->getDisplayInfo();
>     m_capabilities = VRDisplayCapabilities::create(displayInfo.capabilityFlags());
>     m_leftEyeParameters = VREyeParameters::create(displayInfo.eyeTranslation(VRPlatformDisplayInfo::EyeLeft), displayInfo.eyeFieldOfView(VRPlatformDisplayInfo::EyeLeft), displayInfo.renderSize());
>     m_rightEyeParameters = VREyeParameters::create(displayInfo.eyeTranslation(VRPlatformDisplayInfo::EyeRight), displayInfo.eyeFieldOfView(VRPlatformDisplayInfo::EyeRight), displayInfo.renderSize());
>@@ -78,7 +78,7 @@ const VRDisplayCapabilities& VRDisplay::capabilities() const
> 
> RefPtr<VRStageParameters> VRDisplay::stageParameters() const
> {
>-    auto displayInfo = m_display->getDisplayInfo();
>+    auto& displayInfo = m_display->getDisplayInfo();
>     return VRStageParameters::create(displayInfo.sittingToStandingTransform(), displayInfo.playAreaBounds());
> }
> 
>diff --git a/Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py b/Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
>index 0c300876da75ec93cc519245d3156c8518122f53..06be0ea775d4d07a4d68e5163d4448c546c17ac1 100644
>--- a/Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
>+++ b/Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
>@@ -101,6 +101,8 @@ output_file.write("""
> #pragma clang diagnostic ignored "-Wimplicit-fallthrough"
> #endif
> 
>+#define register
>+
> namespace WebCore {
> 
> struct SelectorPseudoClassOrCompatibilityPseudoElementEntry {
>diff --git a/Source/WebCore/css/makeSelectorPseudoElementsMap.py b/Source/WebCore/css/makeSelectorPseudoElementsMap.py
>index 2c9276c981e109d8956367f7f4bb891d2e8fe91b..18311acf4e838accd4bca0afa1ef4290716d616d 100644
>--- a/Source/WebCore/css/makeSelectorPseudoElementsMap.py
>+++ b/Source/WebCore/css/makeSelectorPseudoElementsMap.py
>@@ -99,6 +99,8 @@ output_file.write("""
> #pragma clang diagnostic ignored "-Wimplicit-fallthrough"
> #endif
> 
>+#define register
>+
> namespace WebCore {
> 
> struct SelectorPseudoTypeEntry {
>diff --git a/Source/WebCore/css/makeprop.pl b/Source/WebCore/css/makeprop.pl
>index 3af6952e8b081219528010d9ec57dd9dfc31a404..03d91754ce2cb648ac0e62f0fa04a7ca06029885 100755
>--- a/Source/WebCore/css/makeprop.pl
>+++ b/Source/WebCore/css/makeprop.pl
>@@ -256,6 +256,8 @@ print GPERF << "EOF";
> #pragma clang diagnostic ignored \"-Wimplicit-fallthrough\"
> #endif
> 
>+#define register
>+
> namespace WebCore {
> 
> // Using std::numeric_limits<uint16_t>::max() here would be cleaner,
>diff --git a/Source/WebCore/css/makevalues.pl b/Source/WebCore/css/makevalues.pl
>index 55c4e75097a7fa54a4ab6a126e39ba43398ba55f..1bb87bbde6d0e76c96ee1288bd941838f6c836e0 100755
>--- a/Source/WebCore/css/makevalues.pl
>+++ b/Source/WebCore/css/makevalues.pl
>@@ -80,6 +80,8 @@ print GPERF << "EOF";
> #pragma clang diagnostic ignored \"-Wimplicit-fallthrough\"
> #endif
> 
>+#define register
>+
> namespace WebCore {
> %}
> %struct-type
>diff --git a/Source/WebCore/platform/ColorData.gperf b/Source/WebCore/platform/ColorData.gperf
>index 39123419a385990c6da022f31ae2a45a6c3e0bdb..e331c0b7535fc37116bf01a0a24cf91925f610ce 100644
>--- a/Source/WebCore/platform/ColorData.gperf
>+++ b/Source/WebCore/platform/ColorData.gperf
>@@ -9,6 +9,8 @@
> #pragma clang diagnostic ignored "-Wimplicit-fallthrough"
> #endif
> 
>+#define register
>+
> namespace WebCore {
> %}
> %struct-type
>diff --git a/Source/WebCore/platform/Theme.h b/Source/WebCore/platform/Theme.h
>index 163f35b03f96cf9a53f2c764ef3fb2c641ff0f06..c4dafdef42a0a8d779bab368f139794c544f2c37 100644
>--- a/Source/WebCore/platform/Theme.h
>+++ b/Source/WebCore/platform/Theme.h
>@@ -27,6 +27,7 @@
> 
> #include "ThemeTypes.h"
> #include <wtf/Forward.h>
>+#include <wtf/Optional.h>
> 
> namespace WebCore {
> 
>diff --git a/Source/WebCore/platform/graphics/FloatPoint3D.h b/Source/WebCore/platform/graphics/FloatPoint3D.h
>index d09378152eb42d35ec7626008f1e5f5a96f5a698..fde468d8125f51dc2c8f0b57d148b7bfc4af429a 100644
>--- a/Source/WebCore/platform/graphics/FloatPoint3D.h
>+++ b/Source/WebCore/platform/graphics/FloatPoint3D.h
>@@ -50,13 +50,6 @@ public:
>     {
>     }
> 
>-    FloatPoint3D(const FloatPoint3D& p)
>-        : m_x(p.x())
>-        , m_y(p.y())
>-        , m_z(p.z())
>-    {
>-    }
>-
>     float x() const { return m_x; }
>     void setX(float x) { m_x = x; }
> 
>diff --git a/Source/WebCore/platform/network/create-http-header-name-table b/Source/WebCore/platform/network/create-http-header-name-table
>index 1d4ebcaebd733cd86444325f1e8710ae9dbaea43..03ec1077aa390c4c88dac81623dca86a9af96a36 100755
>--- a/Source/WebCore/platform/network/create-http-header-name-table
>+++ b/Source/WebCore/platform/network/create-http-header-name-table
>@@ -97,6 +97,8 @@ gperf_file.write('''
> #pragma clang diagnostic ignored "-Wimplicit-fallthrough"
> #endif
> 
>+#define register
>+
> namespace WebCore {
> 
> static const struct HeaderNameString {
>diff --git a/Source/WebCore/platform/vr/VRPlatformDisplay.h b/Source/WebCore/platform/vr/VRPlatformDisplay.h
>index 762325cbc44af2f117f086cb901bac0cd09e7238..490ab75ede713ab959c2bc72d3da5ec880a548b1 100644
>--- a/Source/WebCore/platform/vr/VRPlatformDisplay.h
>+++ b/Source/WebCore/platform/vr/VRPlatformDisplay.h
>@@ -159,7 +159,7 @@ struct VRPlatformTrackingInfo {
> 
> class VRPlatformDisplay {
> public:
>-    virtual VRPlatformDisplayInfo getDisplayInfo() = 0;
>+    virtual const VRPlatformDisplayInfo& getDisplayInfo() = 0;
>     virtual VRPlatformTrackingInfo getTrackingInfo() = 0;
>     virtual ~VRPlatformDisplay() = default;
> 
>diff --git a/Source/WebCore/platform/vr/openvr/VRPlatformDisplayOpenVR.h b/Source/WebCore/platform/vr/openvr/VRPlatformDisplayOpenVR.h
>index 3abe3dac079e1d90caa0a85e15b2dd65ec3b3a2b..dfcabe431333f25b3134511d1a4df71045e6b2cf 100644
>--- a/Source/WebCore/platform/vr/openvr/VRPlatformDisplayOpenVR.h
>+++ b/Source/WebCore/platform/vr/openvr/VRPlatformDisplayOpenVR.h
>@@ -33,7 +33,7 @@ public:
>     explicit VRPlatformDisplayOpenVR(vr::IVRSystem*, vr::IVRChaperone*, vr::IVRCompositor*);
> 
>     ~VRPlatformDisplayOpenVR() = default;
>-    VRPlatformDisplayInfo getDisplayInfo() override { return m_displayInfo; }
>+    const VRPlatformDisplayInfo& getDisplayInfo() override { return m_displayInfo; }
>     VRPlatformTrackingInfo getTrackingInfo() override;
> 
> private:
>diff --git a/Source/cmake/WebKitCompilerFlags.cmake b/Source/cmake/WebKitCompilerFlags.cmake
>index 79cae5ff001bf76ba16f091e6daf29cc7dd8f82d..12b7bc8ef45789141005468f480a7b6a8dd6fa1e 100644
>--- a/Source/cmake/WebKitCompilerFlags.cmake
>+++ b/Source/cmake/WebKitCompilerFlags.cmake
>@@ -102,8 +102,19 @@ if (COMPILER_IS_GCC_OR_CLANG)
>                                              -Wno-unknown-argument)
>     else ()
>         WEBKIT_APPEND_GLOBAL_COMPILER_FLAGS(-fno-exceptions)
>-        WEBKIT_APPEND_GLOBAL_CXX_FLAGS(-std=c++17
>-                                       -fno-rtti)
>+        WEBKIT_APPEND_GLOBAL_CXX_FLAGS(-fno-rtti)
>+
>+        check_cxx_compiler_flag("-std=c++17" CXX_COMPILER_SUPPORTS_CXX17)
>+        if (CXX_COMPILER_SUPPORTS_CXX17)
>+            WEBKIT_APPEND_GLOBAL_CXX_FLAGS(-std=c++17)
>+        else ()
>+            check_cxx_compiler_flag("-std=c++1z" CXX_COMPILER_SUPPORTS_CXX1Z)
>+            if (CXX_COMPILER_SUPPORTS_CXX1Z)
>+                WEBKIT_APPEND_GLOBAL_CXX_FLAGS(-std=c++1z)
>+            else ()
>+                message(FATAL_ERROR "Compiler with C++17 support is required")
>+            endif ()
>+        endif ()
> 
>         if (WIN32)
>             WEBKIT_APPEND_GLOBAL_COMPILER_FLAGS(-mno-ms-bitfields)
>diff --git a/ChangeLog b/ChangeLog
>index a146e60ae572e10a7fd85667c90aa9b490e1f27c..4496838450f0f479ca8375eeae688d55e83df6ca 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-05-08  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [GTK] REGRESSION(r231170) Build broken with Clang 5.0
>+        https://bugs.webkit.org/show_bug.cgi?id=185198
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Source/cmake/WebKitCompilerFlags.cmake:
>+
> 2018-05-07  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [JSCOnly] Enable Intl.PluralRules

Actions: View | Formatted Diff | Diff

Attachments on bug 185198: 339322 | 339812 | 339822 | 339842 | 339946 | 339996 | 340303