Attachment 339839 Details for Bug 185431 – Patch

[patch] Patch

bug-185431-20180508111325.patch (text/plain), 7.07 KB, created by youenn fablet on 2018-05-08 11:13:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-05-08 11:13:26 PDT

Size: 7.07 KB

patch

obsolete

>Subversion Revision: 231437
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 33d43bd0acf152229250254f1b3f2f57177b9f6d..5847bb8322b8b697d3ceb4a733048003dd7ad296 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,22 @@
>+2018-05-08  Youenn Fablet  <youenn@apple.com>
>+
>+        Some appcache crash tests are flaky due to console messages
>+        https://bugs.webkit.org/show_bug.cgi?id=185431
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Mark 3 tests that were written to test crashes as DumpJSConsoleLogInStdErr.
>+        It is better to mark them as such than to changing them since they might no longer cover the crash reasons.
>+        Rebase two other tests that might need further work to stop being flaky.
>+
>+        * TestExpectations:
>+        * http/tests/appcache/404-resource-with-slow-main-resource-expected.txt:
>+        * http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt:
>+        * http/tests/appcache/deferred-events-expected.txt:
>+        * http/tests/appcache/fail-on-update-2-expected.txt:
>+        * http/tests/appcache/fail-on-update-expected.txt:
>+        * platform/mac/TestExpectations:
>+
> 2018-05-08  Youenn Fablet  <youenn@apple.com>
> 
>         Skip http/tests/appcache/load-from-appcache-defer-resume-crash.html for iOS sim WK2
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index 7a2bfb01e8f66cc95af9eb7dc6e8411be98e997d..c0973bf09216032d24035b76d03c0ad758997a68 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -1016,8 +1016,9 @@ webkit.org/b/87633 http/tests/appcache/deferred-events-delete-while-raising-time
> webkit.org/b/87633 http/tests/appcache/deferred-events-delete-while-raising.html [ Pass Failure ]
> webkit.org/b/87633 http/tests/appcache/deferred-events.html [ Pass Failure ]
> 
>-webkit.org/b/147520 http/tests/appcache/fail-on-update.html [ Pass Failure ]
>-webkit.org/b/147520 http/tests/appcache/fail-on-update-2.html [ Pass Failure ]
>+http/tests/appcache/fail-on-update.html [ DumpJSConsoleLogInStdErr ]
>+http/tests/appcache/fail-on-update-2.html [ DumpJSConsoleLogInStdErr ]
>+http/tests/appcache/404-resource-with-slow-main-resource.php [ DumpJSConsoleLogInStdErr ]
> 
> webkit.org/b/141370 http/tests/security/appcache-in-private-browsing.html [ Pass Failure ]
> 
>diff --git a/LayoutTests/http/tests/appcache/404-resource-with-slow-main-resource-expected.txt b/LayoutTests/http/tests/appcache/404-resource-with-slow-main-resource-expected.txt
>index 8a95f39d873fe61c30a242c0ec2464ab627b3cd5..ecaf45fa31914a4da7e59a23ab31e300953a7fe7 100644
>--- a/LayoutTests/http/tests/appcache/404-resource-with-slow-main-resource-expected.txt
>+++ b/LayoutTests/http/tests/appcache/404-resource-with-slow-main-resource-expected.txt
>@@ -1,4 +1,2 @@
>-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
>-CONSOLE MESSAGE: Application Cache update failed, because http://127.0.0.1:8000/appcache/resources/does-not-exist.txt could not be fetched.
> This tests that a manifest that contains a missing file will not crash the browser even if the main resource keeps loading after the error occurs.
> SUCCESS
>diff --git a/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt b/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt
>index fe7d83189e153c74d509e4e076b626452352a2fc..e3a90ee53c2d29ae55d56cad9ef0011f6cced9bf 100644
>--- a/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt
>+++ b/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt
>@@ -1,4 +1,4 @@
> CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
>-CONSOLE MESSAGE: line 13: Application Cache download process was aborted.
>+CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
> This tests that download process was aborted after checking event and before update failed.
> SUCCESS
>diff --git a/LayoutTests/http/tests/appcache/deferred-events-expected.txt b/LayoutTests/http/tests/appcache/deferred-events-expected.txt
>index 705bf63c61b6b8247703ee5ba04bb892293e36a7..9332764c9c82014861a0ee3c5d9ede3a35b16607 100644
>--- a/LayoutTests/http/tests/appcache/deferred-events-expected.txt
>+++ b/LayoutTests/http/tests/appcache/deferred-events-expected.txt
>@@ -1,3 +1,4 @@
> CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
>+CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
> Test that AppicationCache events are deferred until after onload has been fired.
> SUCCESS
>diff --git a/LayoutTests/http/tests/appcache/fail-on-update-2-expected.txt b/LayoutTests/http/tests/appcache/fail-on-update-2-expected.txt
>index deb59fc4c70f6fc0f18c19f1a779384e5c3a8820..cd152472483ff01383a74c3925996901683de1e3 100644
>--- a/LayoutTests/http/tests/appcache/fail-on-update-2-expected.txt
>+++ b/LayoutTests/http/tests/appcache/fail-on-update-2-expected.txt
>@@ -1,7 +1 @@
>-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
>-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
>-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
>-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
>-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
>-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
> SUCCESS: No crash.
>diff --git a/LayoutTests/http/tests/appcache/fail-on-update-expected.txt b/LayoutTests/http/tests/appcache/fail-on-update-expected.txt
>index 49383c9ed4d36998143deb79905342a27bc9bd1b..cd152472483ff01383a74c3925996901683de1e3 100644
>--- a/LayoutTests/http/tests/appcache/fail-on-update-expected.txt
>+++ b/LayoutTests/http/tests/appcache/fail-on-update-expected.txt
>@@ -1,4 +1 @@
>-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
>-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
>-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
> SUCCESS: No crash.
>diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations
>index 8708f3744889e377aec2cdbde9d6225dd54ae55d..81bb5019af5cc751d40add59690c1ce1e7efc798 100644
>--- a/LayoutTests/platform/mac/TestExpectations
>+++ b/LayoutTests/platform/mac/TestExpectations
>@@ -1730,8 +1730,6 @@ webkit.org/b/182589 fast/dom/adopt-node-crash-2.html [ Pass Failure ]
> 
> webkit.org/b/181612 [ Debug ] webanimations/animation-opacity-animation-crash.html [ Pass Failure ]
> 
>-webkit.org/b/172241 http/tests/appcache/404-resource-with-slow-main-resource.php [ Pass Failure ]
>-
> webkit.org/b/173946 [ Debug ] media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Pass Failure ]
> 
> webkit.org/b/183490 media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 185431: 339839