Attachment 339814 Details for Bug 185420 – Patch

[patch] Patch

bug-185420-20180508160651.patch (text/plain), 1.74 KB, created by Yacine Bandou on 2018-05-08 07:06:49 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yacine Bandou

Created: 2018-05-08 07:06:49 PDT

Size: 1.74 KB

patch

obsolete

>Subversion Revision: 231044
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 0117bd1b9b40aaabe9e0b4fef12b3a19c5f5202c..cd025269b2cd75491a9573e3ea584b9caa8c07df 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-08  Yacine Bandou  <yacine.bandou_ext@softathome.com>
>+
>+        [EME][GStreamer]  Avoid a crashes after the protection event support is added in 185245
>+        https://bugs.webkit.org/show_bug.cgi?id=185420
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove the ASSERT_NOT_REACHED, because with the patch 185245 this code is reached.
>+        Without this patch, most encrypted-media WPT LayoutTests will crash in debug conf.
>+
>+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
>+        (WebCore::MediaPlayerPrivateGStreamerBase::handleProtectionEvent):
>+
> 2018-05-04  Yacine Bandou  <yacine.bandou_ext@softathome.com>
> 
>         [EME][GStreamer] Add a handler for GStreamer protection event
>diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
>index 2e87676cbcd3379cc7b59feffd0222ab9ac4e81e..6f625d4afb86b17942937adb5c28fb2ad2c58889 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
>@@ -1268,7 +1268,6 @@ void MediaPlayerPrivateGStreamerBase::handleProtectionEvent(GstEvent* event)
>     const gchar* eventKeySystemId = nullptr;
>     gst_event_parse_protection(event, &eventKeySystemId, nullptr, nullptr);
>     GST_WARNING("FIXME: unhandled protection event for %s", eventKeySystemId);
>-    ASSERT_NOT_REACHED();
> }
> #endif
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185420: 339814