Attachment 339812 Details for Bug 185198 – WIP

[patch] WIP

bug-185198-20180508155533.patch (text/plain), 8.30 KB, created by Zan Dobersek on 2018-05-08 06:55:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2018-05-08 06:55:34 PDT

Size: 8.30 KB

patch

obsolete

>Subversion Revision: 231482
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index bc6041bf7ed5b8f9814df3647ef6f4054b41e3c8..25a804a3988520eb26ae006cad039b0a74ef79e2 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-08  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [GTK] REGRESSION(r231170) Build broken with Clang (5.0)
>+        https://bugs.webkit.org/show_bug.cgi?id=185198
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/Compiler.h:
>+        * wtf/Forward.h:
>+        * wtf/Hasher.h:
>+        * wtf/Optional.h:
>+
> 2018-05-07  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [JSCONLY] Enable ARMv7 DFG
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 9978f968a09a6e95f12bfc811c4711f7d5951d57..549c43b1c790e2b08361b5068b0a4bb636c3f45e 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-05-08  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [GTK] REGRESSION(r231170) Build broken with Clang (5.0)
>+        https://bugs.webkit.org/show_bug.cgi?id=185198
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * css/makeSelectorPseudoClassAndCompatibilityElementMap.py:
>+        * css/makeSelectorPseudoElementsMap.py:
>+        * css/makeprop.pl:
>+        * css/makevalues.pl:
>+        * platform/ColorData.gperf:
>+        * platform/Theme.h:
>+        * platform/network/create-http-header-name-table:
>+
> 2018-05-07  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Add FormattingContext::layoutOutOfFlowDescendants implementation
>diff --git a/Source/WTF/wtf/Compiler.h b/Source/WTF/wtf/Compiler.h
>index 1391eadf8ed1cfa280dfcdf5a3612097d73abe33..31c2936911ffb96fbb003d4a27b6996ccf804682 100644
>--- a/Source/WTF/wtf/Compiler.h
>+++ b/Source/WTF/wtf/Compiler.h
>@@ -74,6 +74,8 @@
> #define WTF_CPP_STD_VER 11
> #elif __cplusplus <= 201402L
> #define WTF_CPP_STD_VER 14
>+#elif __cplusplus <= 201703L
>+#define WTF_CPP_STD_VER 17
> #endif
> #endif
> 
>diff --git a/Source/WTF/wtf/Forward.h b/Source/WTF/wtf/Forward.h
>index 81938fce41d6138f3de362a5f89c5dbfbd2d701f..dde7ec030b76f020f82dcbb5e884a4634fabd9a9 100644
>--- a/Source/WTF/wtf/Forward.h
>+++ b/Source/WTF/wtf/Forward.h
>@@ -22,10 +22,6 @@
> 
> #include <stddef.h>
> 
>-namespace std {
>-template<typename T> class optional;
>-}
>-
> namespace WTF {
> 
> class AtomicString;
>diff --git a/Source/WTF/wtf/Hasher.h b/Source/WTF/wtf/Hasher.h
>index 1439391cd52020a8ce98b28311e342dd8e3098cc..e3496e6d33bec652bfd0822247c0e3de9896c54e 100644
>--- a/Source/WTF/wtf/Hasher.h
>+++ b/Source/WTF/wtf/Hasher.h
>@@ -21,6 +21,7 @@
> #pragma once
> 
> #include <wtf/Forward.h>
>+#include <wtf/Optional.h>
> #include <wtf/StdLibExtras.h>
> #include <wtf/text/StringHasher.h>
> 
>diff --git a/Source/WTF/wtf/Optional.h b/Source/WTF/wtf/Optional.h
>index 67ee27752ff908202b37ba85a71d1580f71b6101..d8c2136c2025ab0db0b0a73ced2e300627906f49 100644
>--- a/Source/WTF/wtf/Optional.h
>+++ b/Source/WTF/wtf/Optional.h
>@@ -216,6 +216,13 @@ template <class T> class optional;
> // 20.5.5, optional for lvalue reference types
> template <class T> class optional<T&>;
> 
>+#if defined(__GLIBCXX__) && !defined(_GLIBCXX_RELEASE)
>+
>+struct in_place_t { };
>+constexpr in_place_t in_place { };
>+
>+#endif
>+
> namespace detail_ {
> 
> // workaround: std utility functions aren't constexpr yet
>diff --git a/Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py b/Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
>index 0c300876da75ec93cc519245d3156c8518122f53..06be0ea775d4d07a4d68e5163d4448c546c17ac1 100644
>--- a/Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
>+++ b/Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
>@@ -101,6 +101,8 @@ output_file.write("""
> #pragma clang diagnostic ignored "-Wimplicit-fallthrough"
> #endif
> 
>+#define register
>+
> namespace WebCore {
> 
> struct SelectorPseudoClassOrCompatibilityPseudoElementEntry {
>diff --git a/Source/WebCore/css/makeSelectorPseudoElementsMap.py b/Source/WebCore/css/makeSelectorPseudoElementsMap.py
>index 2c9276c981e109d8956367f7f4bb891d2e8fe91b..18311acf4e838accd4bca0afa1ef4290716d616d 100644
>--- a/Source/WebCore/css/makeSelectorPseudoElementsMap.py
>+++ b/Source/WebCore/css/makeSelectorPseudoElementsMap.py
>@@ -99,6 +99,8 @@ output_file.write("""
> #pragma clang diagnostic ignored "-Wimplicit-fallthrough"
> #endif
> 
>+#define register
>+
> namespace WebCore {
> 
> struct SelectorPseudoTypeEntry {
>diff --git a/Source/WebCore/css/makeprop.pl b/Source/WebCore/css/makeprop.pl
>index 3af6952e8b081219528010d9ec57dd9dfc31a404..03d91754ce2cb648ac0e62f0fa04a7ca06029885 100755
>--- a/Source/WebCore/css/makeprop.pl
>+++ b/Source/WebCore/css/makeprop.pl
>@@ -256,6 +256,8 @@ print GPERF << "EOF";
> #pragma clang diagnostic ignored \"-Wimplicit-fallthrough\"
> #endif
> 
>+#define register
>+
> namespace WebCore {
> 
> // Using std::numeric_limits<uint16_t>::max() here would be cleaner,
>diff --git a/Source/WebCore/css/makevalues.pl b/Source/WebCore/css/makevalues.pl
>index 55c4e75097a7fa54a4ab6a126e39ba43398ba55f..1bb87bbde6d0e76c96ee1288bd941838f6c836e0 100755
>--- a/Source/WebCore/css/makevalues.pl
>+++ b/Source/WebCore/css/makevalues.pl
>@@ -80,6 +80,8 @@ print GPERF << "EOF";
> #pragma clang diagnostic ignored \"-Wimplicit-fallthrough\"
> #endif
> 
>+#define register
>+
> namespace WebCore {
> %}
> %struct-type
>diff --git a/Source/WebCore/platform/ColorData.gperf b/Source/WebCore/platform/ColorData.gperf
>index 39123419a385990c6da022f31ae2a45a6c3e0bdb..e331c0b7535fc37116bf01a0a24cf91925f610ce 100644
>--- a/Source/WebCore/platform/ColorData.gperf
>+++ b/Source/WebCore/platform/ColorData.gperf
>@@ -9,6 +9,8 @@
> #pragma clang diagnostic ignored "-Wimplicit-fallthrough"
> #endif
> 
>+#define register
>+
> namespace WebCore {
> %}
> %struct-type
>diff --git a/Source/WebCore/platform/Theme.h b/Source/WebCore/platform/Theme.h
>index 163f35b03f96cf9a53f2c764ef3fb2c641ff0f06..c4dafdef42a0a8d779bab368f139794c544f2c37 100644
>--- a/Source/WebCore/platform/Theme.h
>+++ b/Source/WebCore/platform/Theme.h
>@@ -27,6 +27,7 @@
> 
> #include "ThemeTypes.h"
> #include <wtf/Forward.h>
>+#include <wtf/Optional.h>
> 
> namespace WebCore {
> 
>diff --git a/Source/WebCore/platform/network/create-http-header-name-table b/Source/WebCore/platform/network/create-http-header-name-table
>index 1d4ebcaebd733cd86444325f1e8710ae9dbaea43..03ec1077aa390c4c88dac81623dca86a9af96a36 100755
>--- a/Source/WebCore/platform/network/create-http-header-name-table
>+++ b/Source/WebCore/platform/network/create-http-header-name-table
>@@ -97,6 +97,8 @@ gperf_file.write('''
> #pragma clang diagnostic ignored "-Wimplicit-fallthrough"
> #endif
> 
>+#define register
>+
> namespace WebCore {
> 
> static const struct HeaderNameString {
>diff --git a/Source/cmake/WebKitCompilerFlags.cmake b/Source/cmake/WebKitCompilerFlags.cmake
>index 79cae5ff001bf76ba16f091e6daf29cc7dd8f82d..12b7bc8ef45789141005468f480a7b6a8dd6fa1e 100644
>--- a/Source/cmake/WebKitCompilerFlags.cmake
>+++ b/Source/cmake/WebKitCompilerFlags.cmake
>@@ -102,8 +102,19 @@ if (COMPILER_IS_GCC_OR_CLANG)
>                                              -Wno-unknown-argument)
>     else ()
>         WEBKIT_APPEND_GLOBAL_COMPILER_FLAGS(-fno-exceptions)
>-        WEBKIT_APPEND_GLOBAL_CXX_FLAGS(-std=c++17
>-                                       -fno-rtti)
>+        WEBKIT_APPEND_GLOBAL_CXX_FLAGS(-fno-rtti)
>+
>+        check_cxx_compiler_flag("-std=c++17" CXX_COMPILER_SUPPORTS_CXX17)
>+        if (CXX_COMPILER_SUPPORTS_CXX17)
>+            WEBKIT_APPEND_GLOBAL_CXX_FLAGS(-std=c++17)
>+        else ()
>+            check_cxx_compiler_flag("-std=c++1z" CXX_COMPILER_SUPPORTS_CXX1Z)
>+            if (CXX_COMPILER_SUPPORTS_CXX1Z)
>+                WEBKIT_APPEND_GLOBAL_CXX_FLAGS(-std=c++1z)
>+            else ()
>+                message(FATAL_ERROR "Compiler with C++17 support is required")
>+            endif ()
>+        endif ()
> 
>         if (WIN32)
>             WEBKIT_APPEND_GLOBAL_COMPILER_FLAGS(-mno-ms-bitfields)
>diff --git a/ChangeLog b/ChangeLog
>index a146e60ae572e10a7fd85667c90aa9b490e1f27c..cd30f895980948cb6dee6648b101c4b770ff59cf 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-05-08  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [GTK] REGRESSION(r231170) Build broken with Clang (5.0)
>+        https://bugs.webkit.org/show_bug.cgi?id=185198
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Source/cmake/WebKitCompilerFlags.cmake:
>+
> 2018-05-07  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [JSCOnly] Enable Intl.PluralRules

Actions: View | Formatted Diff | Diff

Attachments on bug 185198: 339322 | 339812 | 339822 | 339842 | 339946 | 339996 | 340303