WebKit Bugzilla
Attachment 339799 Details for
Bug 185414
: [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185414-20180507221942.patch (text/plain), 2.24 KB, created by
Wenson Hsieh
on 2018-05-07 22:19:43 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Wenson Hsieh
Created:
2018-05-07 22:19:43 PDT
Size:
2.24 KB
patch
obsolete
>Subversion Revision: 231385 >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 5316f6465c6a9d226a48a1b4fb53a1de7253100c..6dd027cd20ff56f937fa0c5675f50135cc50cb09 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,17 @@ >+2018-05-07 Wenson Hsieh <wenson_hsieh@apple.com> >+ >+ [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396 >+ https://bugs.webkit.org/show_bug.cgi?id=185414 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Adjust a test expectation to check that the resulting DOM contains an attachment element, >+ anchor element, and another attachment element in that order. This ensures that the test >+ still passes, even after the anchor element is followed by a line break. >+ >+ * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm: >+ (TestWebKitAPI::TEST): >+ > 2018-05-04 Timothy Hatcher <timothy@apple.com> > > Deprecate legacy WebView and friends >diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm >index b9a32c9a6aede87fe7a167d45cc8f7b49815f634..4689da43b3b7b191ab081df1ecbab4281dc038bf 100644 >--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm >+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm >@@ -1338,11 +1338,7 @@ TEST(WKAttachmentTestsIOS, InsertDroppedItemProvidersInOrder) > NSLog(@"Error: %@", error); > } > >- NSArray *observedElementTags = (NSArray *)[webView objectByEvaluatingJavaScript:@"Array.from(document.body.children).map(e => e.tagName)"]; >- NSArray *expectedElementTags = @[ @"ATTACHMENT", @"A", @"ATTACHMENT" ]; >- EXPECT_TRUE([observedElementTags isEqualToArray:expectedElementTags]); >- if (![observedElementTags isEqualToArray:expectedElementTags]) >- NSLog(@"Observed elements: %@ did not match expectations: %@", observedElementTags, expectedElementTags); >+ [webView expectElementTagsInOrder:@[ @"ATTACHMENT", @"A", @"ATTACHMENT" ]]; > > EXPECT_WK_STREQ("first.txt", [webView stringByEvaluatingJavaScript:@"document.querySelectorAll('attachment')[0].getAttribute('title')"]); > EXPECT_WK_STREQ("text/plain", [webView stringByEvaluatingJavaScript:@"document.querySelectorAll('attachment')[0].getAttribute('type')"]);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185414
: 339799 |
339805