Attachment 339787 Details for Bug 185409 – Patch

[patch] Patch

bug-185409-20180507190137.patch (text/plain), 3.45 KB, created by Sam Weinig on 2018-05-07 19:01:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Weinig

Created: 2018-05-07 19:01:38 PDT

Size: 3.45 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 231474)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2018-05-07  Sam Weinig  <sam@webkit.org>
>+
>+        More cleanup of XMLHttpRequestUpload
>+        https://bugs.webkit.org/show_bug.cgi?id=185409
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        - Remove unneeded #includes
>+        - Rename m_xmlHttpRequest to m_request
>+        - Make some overloaded some methods private, and mark them as final rather
>+          than override.
>+
>+        * xml/XMLHttpRequestUpload.cpp:
>+        (WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
>+        * xml/XMLHttpRequestUpload.h:
>+
> 2018-05-07  Simon Fraser  <simon.fraser@apple.com>
> 
>         CSS filters which reference SVG filters fail to respect the "color-interpolation-filters" of the filter
>Index: Source/WebCore/xml/XMLHttpRequestUpload.cpp
>===================================================================
>--- Source/WebCore/xml/XMLHttpRequestUpload.cpp	(revision 231470)
>+++ Source/WebCore/xml/XMLHttpRequestUpload.cpp	(working copy)
>@@ -26,7 +26,6 @@
> #include "config.h"
> #include "XMLHttpRequestUpload.h"
> 
>-#include "Event.h"
> #include "EventNames.h"
> #include "XMLHttpRequestProgressEvent.h"
> #include <wtf/Assertions.h>
>@@ -34,8 +33,8 @@
> 
> namespace WebCore {
> 
>-XMLHttpRequestUpload::XMLHttpRequestUpload(XMLHttpRequest& xmlHttpRequest)
>-    : m_xmlHttpRequest(xmlHttpRequest)
>+XMLHttpRequestUpload::XMLHttpRequestUpload(XMLHttpRequest& request)
>+    : m_request(request)
> {
> }
> 
>@@ -61,5 +60,4 @@ void XMLHttpRequestUpload::dispatchProgr
>     dispatchEvent(XMLHttpRequestProgressEvent::create(type, m_lengthComputable, m_loaded, m_total));
> }
> 
>-
> } // namespace WebCore
>Index: Source/WebCore/xml/XMLHttpRequestUpload.h
>===================================================================
>--- Source/WebCore/xml/XMLHttpRequestUpload.h	(revision 231470)
>+++ Source/WebCore/xml/XMLHttpRequestUpload.h	(working copy)
>@@ -27,8 +27,6 @@
> 
> #include "XMLHttpRequest.h"
> #include <wtf/Forward.h>
>-#include <wtf/RefCounted.h>
>-#include <wtf/RefPtr.h>
> 
> namespace WebCore {
> 
>@@ -37,12 +35,8 @@ class XMLHttpRequestUpload final : publi
> public:
>     explicit XMLHttpRequestUpload(XMLHttpRequest&);
> 
>-    void ref() { m_xmlHttpRequest.ref(); }
>-    void deref() { m_xmlHttpRequest.deref(); }
>-    XMLHttpRequest& xmlHttpRequest() const { return m_xmlHttpRequest; }
>-
>-    EventTargetInterface eventTargetInterface() const override { return XMLHttpRequestUploadEventTargetInterfaceType; }
>-    ScriptExecutionContext* scriptExecutionContext() const override { return m_xmlHttpRequest.scriptExecutionContext(); }
>+    void ref() { m_request.ref(); }
>+    void deref() { m_request.deref(); }
> 
>     void dispatchThrottledProgressEvent(bool lengthComputable, unsigned long long loaded, unsigned long long total);
>     void dispatchProgressEvent(const AtomicString& type);
>@@ -51,7 +45,10 @@ private:
>     void refEventTarget() final { ref(); }
>     void derefEventTarget() final { deref(); }
> 
>-    XMLHttpRequest& m_xmlHttpRequest;
>+    EventTargetInterface eventTargetInterface() const final { return XMLHttpRequestUploadEventTargetInterfaceType; }
>+    ScriptExecutionContext* scriptExecutionContext() const final { return m_request.scriptExecutionContext(); }
>+
>+    XMLHttpRequest& m_request;
>     bool m_lengthComputable { false };
>     unsigned long long m_loaded { 0 };
>     unsigned long long m_total { 0 };

Actions: View | Formatted Diff | Diff

Attachments on bug 185409: 339787 | 339798