Attachment 339783 Details for Bug 185369 – Patch

[patch] Patch

bug-185369-20180507181016.patch (text/plain), 1.89 KB, created by Matt Baker on 2018-05-07 18:10:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2018-05-07 18:10:16 PDT

Size: 1.89 KB

patch

obsolete

>Subversion Revision: 231460
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 82a03283a4edd8deb0b674aae0e4c4c483002d81..eb353af5e9f1156e2251b52aa2b4d3a6b3ddae27 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-05-07  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: Console drawer resizing is broken when console prompt has >1 line of code
>+        https://bugs.webkit.org/show_bug.cgi?id=185369
>+        <rdar://problem/40013202>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Mouse offset calculation should account for the height of the quick console.
>+        The only reason resizing worked with the single-line quick console is that
>+        the offset calculation included the resizer height, which is very close
>+        to that of the single-line quick console (27px and 30px respectively).
>+
>+        * UserInterface/Views/ConsoleDrawer.js:
>+
> 2018-05-04  Devin Rousso  <webkit@devinrousso.com>
> 
>         Web Inspector: simplify the WI.Collection interface
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js b/Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js
>index e58231ad0ff8772212ca08f6797a9c1670db4b4f..3e0f663b6e0acad341486b6c025c946bf1fb3a25 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js
>@@ -122,7 +122,8 @@ WI.ConsoleDrawer = class ConsoleDrawer extends WI.ContentBrowser
>             return;
> 
>         let resizerElement = event.target;
>-        let mouseOffset = resizerElement.offsetHeight - (event.pageY - resizerElement.totalOffsetTop);
>+        let quickConsoleHeight = window.innerHeight - (this.element.totalOffsetTop + this.height);
>+        let mouseOffset = quickConsoleHeight - (event.pageY - resizerElement.totalOffsetTop);
> 
>         function dockedResizerDrag(event)
>         {

Actions: View | Formatted Diff | Diff

Attachments on bug 185369: 339701 | 339783 | 339784