Attachment 339770 Details for Bug 185403 – Patch

[patch] Patch

bug-185403-20180507165346.patch (text/plain), 2.11 KB, created by Alex Christensen on 2018-05-07 16:53:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-05-07 16:53:46 PDT

Size: 2.11 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 231464)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2018-05-07  Alex Christensen  <achristensen@webkit.org>
>+
>+        WebResourceLoadStatisticsStore::requestStorageAccess should call its completion handler on the main thread
>+        https://bugs.webkit.org/show_bug.cgi?id=185403
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/WebResourceLoadStatisticsStore.cpp:
>+        (WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
>+
> 2018-05-07  Chris Dumez  <cdumez@apple.com>
> 
>         [iOS] Release page load process assertion if the screen is locked
>Index: Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp
>===================================================================
>--- Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp	(revision 231460)
>+++ Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp	(working copy)
>@@ -371,18 +371,26 @@ void WebResourceLoadStatisticsStore::req
> 
>         auto& subFrameStatistic = ensureResourceStatisticsForPrimaryDomain(subFramePrimaryDomain);
>         if (shouldBlockCookies(subFrameStatistic)) {
>-            callback(false);
>+            callOnMainThread([callback = WTFMove(callback)] {
>+                callback(false);
>+            });
>             return;
>         }
>         
>         if (!shouldPartitionCookies(subFrameStatistic)) {
>-            callback(true);
>+            callOnMainThread([callback = WTFMove(callback)] {
>+                callback(true);
>+            });
>             return;
>         }
> 
>         subFrameStatistic.timesAccessedAsFirstPartyDueToStorageAccessAPI++;
> 
>-        m_grantStorageAccessHandler(subFramePrimaryDomain, topFramePrimaryDomain, frameID, pageID, WTFMove(callback));
>+        m_grantStorageAccessHandler(subFramePrimaryDomain, topFramePrimaryDomain, frameID, pageID, [callback = WTFMove(callback)] (bool value) mutable {
>+            callOnMainThread([value, callback = WTFMove(callback)] {
>+                callback(value);
>+            });
>+        });
>     });
> }
>

Flags:

bfulgham: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185403: 339770