Attachment 339766 Details for Bug 185335 – Patch

[patch] Patch

bug-185335-20180507163624.patch (text/plain), 2.59 KB, created by Brent Fulgham on 2018-05-07 16:36:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2018-05-07 16:36:24 PDT

Size: 2.59 KB

patch

obsolete

>Subversion Revision: 231459
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index df7a7d304de6f54d3ab3bfcbc555753578e1b13c..47743f8f47d5426ba8dc0acdd2af0d9bfe8bec8e 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-07  Brent Fulgham  <bfulgham@apple.com>
>+
>+        Add experimental feature to prompt for Storage Access API use
>+        https://bugs.webkit.org/show_bug.cgi?id=185335
>+        <rdar://problem/39994649>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The 'requestStorageAccess' method of WebsiteDataStore performs operations on a background queue. We need to dispatch back
>+        to the main thread for m_uiClient activities.
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::requestStorageAccess):
>+
> 2018-05-07  Chris Dumez  <cdumez@apple.com>
> 
>         [iOS] Release page load process assertion if the screen is locked
>diff --git a/Source/WebKit/UIProcess/WebPageProxy.cpp b/Source/WebKit/UIProcess/WebPageProxy.cpp
>index 4bca575d3c07baa2aac1ef5259c0b729e5d44614..01be1077f8b162a36a22403378c64f681a17d6c3 100644
>--- a/Source/WebKit/UIProcess/WebPageProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebPageProxy.cpp
>@@ -7487,13 +7487,15 @@ void WebPageProxy::requestStorageAccess(String&& subFrameHost, String&& topFrame
>     String requestingDomain = subFrameHost;
>     String currentDomain = topFrameHost;
>     m_websiteDataStore->requestStorageAccess(WTFMove(subFrameHost), WTFMove(topFrameHost), frameID, m_pageID, [this, protectedThis = makeRef(*this), requestingDomain = WTFMove(requestingDomain), currentDomain = WTFMove(currentDomain), promptEnabled, frameID, completionHandler = WTFMove(completionHandler)] (bool wasGranted) mutable {
>-        if (!wasGranted)
>-            return completionHandler(false);
>-        
>-        if (!promptEnabled)
>-            return completionHandler(true);
>+        RunLoop::main().dispatch([this, protectedThis = makeRef(*this), requestingDomain = WTFMove(requestingDomain), currentDomain = WTFMove(currentDomain), promptEnabled, wasGranted, frameID, completionHandler = WTFMove(completionHandler)] () mutable {
>+            if (!wasGranted)
>+                return completionHandler(false);
> 
>-        m_uiClient->requestStorageAccessConfirm(*this, m_process->webFrame(frameID), requestingDomain, currentDomain, WTFMove(completionHandler));
>+            if (!promptEnabled)
>+                return completionHandler(true);
>+
>+            m_uiClient->requestStorageAccessConfirm(*this, m_process->webFrame(frameID), requestingDomain, currentDomain, WTFMove(completionHandler));
>+        });
>     });
> }
> #endif

Flags:

achristensen: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 185335: 339616 | 339651 | 339652 | 339655 | 339659 | 339693 | 339697 | 339700 | 339735 | 339742 | 339745 | 339755 | 339766