Attachment 339748 Details for Bug 185391 – Patch

[patch] Patch

bug-185391-20180507135051.patch (text/plain), 1.73 KB, created by Dean Jackson on 2018-05-07 13:50:51 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Jackson

Created: 2018-05-07 13:50:51 PDT

Size: 1.73 KB

patch

obsolete

>Subversion Revision: 231399
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 6bc61b61b4fa0246738dc1fa2eae9f8e23d6f533..bd7cb7168d99c0df2cf3ea3e05f01da55d2743d9 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-07  Dean Jackson  <dino@apple.com>
>+
>+        Use a dark gray for system preview bbackground
>+        https://bugs.webkit.org/show_bug.cgi?id=185391
>+        <rdar://problem/40035120>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Throw some darker shade at this view.
>+
>+        * UIProcess/ios/WKSystemPreviewView.mm:
>+        (-[WKSystemPreviewView web_initWithFrame:webView:]):
>+
> 2018-05-04  Tim Horton  <timothy_horton@apple.com>
> 
>         Shift to a lower-level framework for simplifying URLs
>diff --git a/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm b/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm
>index 8527507695cdf7fb776b10ebf6871ccfbf43c155..843f1cddd5f926ecc201c9076d4b5fd10783e575 100644
>--- a/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm
>+++ b/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm
>@@ -61,14 +61,15 @@ SOFT_LINK_CLASS(QuickLook, QLPreviewController);
>     if (!(self = [super initWithFrame:frame]))
>         return nil;
> 
>-    self.backgroundColor = [UIColor lightGrayColor];
>+    UIColor *backgroundColor = [UIColor colorWithRed:(38. / 255) green:(38. / 255) blue:(38. / 255) alpha:1]
>+    self.backgroundColor = [UIColor backgroundColor];
> 
>     _webView = webView;
> 
>     UIScrollView *scrollView = webView.scrollView;
>     [scrollView setMinimumZoomScale:1];
>     [scrollView setMaximumZoomScale:1];
>-    [scrollView setBackgroundColor:[UIColor lightGrayColor]];
>+    [scrollView setBackgroundColor:[UIColor backgroundColor]];
> 
>     return self;
> }

Flags:

eric.carlson: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185391: 339748